You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2020/01/06 13:38:13 UTC
[GitHub] [bookkeeper] eolivelli opened a new pull request #2233: Drop Maven
Profile -Dstream
eolivelli opened a new pull request #2233: Drop Maven Profile -Dstream
URL: https://github.com/apache/bookkeeper/pull/2233
Descriptions of the changes in this PR:
### Motivation
The "stream" profile enables the build of all of the additional packages regarding the 'table service'.
This profile complicates a lot every script and the Maven project.
As the stream storage service is now stable and used in production, it is better to always include those modules.
Regualar developers on bookkeeper-server module won't be affected by this change as it affects only the full build and the release process.
### Changes
Modify every pom.xml in order to enable all of the parts of the pom.xml that would be enabled with '-Dstream'.
Modify release scripts by removing references to -Dstream
Modify bin/common.sh about the auto build feature
Modify Groovy scripts for Jenkins
I did not modify the website because currently the precommit validation of the website is broken
> ---
> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
> checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
> the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
> can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
> you are not sure, committers will help you:
>
> - [ ] [skip bookkeeper-server bookie tests]: skip testing `org.apache.bookkeeper.bookie` in bookkeeper-server module.
> - [ ] [skip bookkeeper-server client tests]: skip testing `org.apache.bookkeeper.client` in bookkeeper-server module.
> - [ ] [skip bookkeeper-server replication tests]: skip testing `org.apache.bookkeeper.replication` in bookkeeper-server module.
> - [ ] [skip bookkeeper-server tls tests]: skip testing `org.apache.bookkeeper.tls` in bookkeeper-server module.
> - [ ] [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
> - [ ] [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
> - [ ] [skip build java8]: skip build on java8. *ONLY* skip this when *ONLY* changing files under documentation under `site`.
> - [ ] [skip build java11]: skip build on java11. *ONLY* skip this when *ONLY* changing files under documentation under `site`.
> ---
> ---
> Be sure to do all of the following to help us incorporate your contribution
> quickly and easily:
>
> If this PR is a BookKeeper Proposal (BP):
>
> - [ ] Make sure the PR title is formatted like:
> `<BP-#>: Description of bookkeeper proposal`
> `e.g. BP-1: 64 bits ledger is support`
> - [ ] Attach the master issue link in the description of this PR.
> - [ ] Attach the google doc link if the BP is written in Google Doc.
>
> Otherwise:
>
> - [ ] Make sure the PR title is formatted like:
> `<Issue #>: Description of pull request`
> `e.g. Issue 123: Description ...`
> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
> - [ ] Replace `<Issue #>` in the title with the actual Issue number.
>
> ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] jiazhai merged pull request #2233: Drop Maven Profile
-Dstream
Posted by GitBox <gi...@apache.org>.
jiazhai merged pull request #2233: Drop Maven Profile -Dstream
URL: https://github.com/apache/bookkeeper/pull/2233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2233: Drop Maven Profile
-Dstream
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2233: Drop Maven Profile -Dstream
URL: https://github.com/apache/bookkeeper/pull/2233#issuecomment-596089413
@jiazhai can you please help merging this patch ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2233: Drop Maven Profile
-Dstream
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2233: Drop Maven Profile -Dstream
URL: https://github.com/apache/bookkeeper/pull/2233#issuecomment-579206845
It looks like on CI Maven is trying to download distributedlog from repository.apache.org
Downloaded from apache.snapshots: https://repository.apache.org/snapshots/org/apache/distributedlog/distributedlog-core/4.11.0-SNAPSHOT/distributedlog-core-4.11.0-20200127.150249-85.jar (1.0 MB at 1.1 MB/s)
Downloading from central: https://repo.maven.apache.org/maven2/net/jpountz/lz4/lz4/1.3.0/lz4-1.3.0.jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2233: Drop Maven Profile
-Dstream
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2233: Drop Maven Profile -Dstream
URL: https://github.com/apache/bookkeeper/pull/2233#issuecomment-571192184
Travis is failing again by complaining about the lack of the same jars I fixed in #2228
I am investigating
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2233: Drop Maven Profile
-Dstream
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2233: Drop Maven Profile -Dstream
URL: https://github.com/apache/bookkeeper/pull/2233#issuecomment-571183868
run bookkeeper-server bookie tests
run bookkeeper-server replication tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli edited a comment on issue #2233: Drop Maven
Profile -Dstream
Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on issue #2233: Drop Maven Profile -Dstream
URL: https://github.com/apache/bookkeeper/pull/2233#issuecomment-579206845
It looks like on CI Maven is trying to download distributedlog from repository.apache.org
```
Downloaded from apache.snapshots: https://repository.apache.org/snapshots/org/apache/distributedlog/distributedlog-core/4.11.0-SNAPSHOT/distributedlog-core-4.11.0-20200127.150249-85.jar (1.0 MB at 1.1 MB/s)
Downloading from central: https://repo.maven.apache.org/maven2/net/jpountz/lz4/lz4/1.3.0/lz4-1.3.0.jar
```
then there is a bad timeout error on "statelib" error:
`[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.21.0:test (default-test) on project statelib: There was a timeout or other error in the fork -> [Help 1]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [bookkeeper] eolivelli commented on issue #2233: Drop Maven Profile
-Dstream
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #2233: Drop Maven Profile -Dstream
URL: https://github.com/apache/bookkeeper/pull/2233#issuecomment-578046636
@jiazhai can you please help merging this patch ?
We are migrating to github actions so CI status is not so clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services