[GitHub] [kafka] kirktrue commented on a diff in pull request #13921: MINOR: Reduce (hopefully) flakiness of testRackAwareRangeAssignor

["kirktrue (via GitHub)" <gi...@apache.org>]

kirktrue commented on code in PR #13921:
URL: https://github.com/apache/kafka/pull/13921#discussion_r1243822717


##########
core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala:
##########
@@ -249,6 +249,9 @@ class FetchFromFollowerIntegrationTest extends BaseFetchRequestTest {
         reassignments.put(new TopicPartition(topicWithSingleRackPartitions, p), util.Optional.of(newAssignment))
       }
       admin.alterPartitionReassignments(reassignments).all().get(30, TimeUnit.SECONDS)
+      TestUtils.waitUntilTrue(
+        () => admin.listPartitionReassignments().reassignments().get().isEmpty,

Review Comment:
   Do we want to pass in a timeout to `get` in case it hangs?
   
   ```suggestion
           () => admin.listPartitionReassignments().reassignments().get(30, TimeUnit.SECONDS).isEmpty,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org