You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/11/16 20:40:56 UTC

[GitHub] [druid] gianm opened a new pull request #11931: DruidViewMacro: Remove unused escalator field.

gianm opened a new pull request #11931:
URL: https://github.com/apache/druid/pull/11931


   It isn't used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] kfaraz commented on pull request #11931: DruidViewMacro: Remove unused escalator field.

Posted by GitBox <gi...@apache.org>.
kfaraz commented on pull request #11931:
URL: https://github.com/apache/druid/pull/11931#issuecomment-971203113


   Should `DruidViewMacroFactory` also be updated to remove the `escalator` argument?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] clintropolis merged pull request #11931: DruidViewMacro: Remove unused escalator field.

Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #11931:
URL: https://github.com/apache/druid/pull/11931


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] gianm commented on pull request #11931: DruidViewMacro: Remove unused escalator field.

Posted by GitBox <gi...@apache.org>.
gianm commented on pull request #11931:
URL: https://github.com/apache/druid/pull/11931#issuecomment-973140616


   @kfaraz Good point; I removed that as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org