You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Josh Tynjala <jo...@gmail.com> on 2016/12/16 23:42:06 UTC
[FlexJS] Updated Closure compiler from v20151015 to v20161201
Hey folks,
I updated flex-falcon to use a newer build of Closure compiler,
specifically v20161201. This also required an update of the Guava
dependency from v17.0 to v20.0. I have made the required changes to the
dependencies for both Ant and Maven builds.
An update to Closure compiler means that we have the latest features and
bug fixes from Google for optimizing our JS release builds. For instance,
one new feature that prompted my desire to update should allow us to
improve JS source maps for release builds (to step through the original
ActionScript instead of the generated js-debug JavaScript). It also means
updated externs with the newest JavaScript browser APIs becoming exposed to
ActionScript. Finally, the v20151015 build is getting to be over a year old
now, and the longer we wait to update, the harder it will become!
This change also affected the flex-typedefs and flex-asjs repositories a
bit. I had to make a few tweaks here and there because Closure compiler or
the externs became a little more strict, and some APIs were renamed. I
think I got everything running properly because the DataBindingExample
works correctly, but I encourage you to test more examples to be sure that
I didn't miss anything.
If you're using the Ant build, you need to be sure to wipe before building
each of the repositories after you pull the latest changes. Be sure to pull
from all three repos! This will ensure that the new dependencies are
downloaded to replace the old ones, and everything will be in sync.
flex-falcon:
ant wipe-all
flex-typedefs:
ant wipe
flex-asjs:
ant super-clean
I ran all of these on the Ant CI server, and I'll make tweaks as needed if
anything appears to break.
- Josh
Re: AW: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by Alex Harui <ah...@adobe.com>.
Maven has been updated as well.
Sent from my LG G3, an AT&T 4G LTE smartphone
------ Original message------
From: Carlos Rovira
Date: Sun, Dec 18, 2016 1:05 PM
To: dev@flex.apache.org;
Cc: christofer.dutz@c-ware.de;
Subject:Re: AW: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Hi, Thanks Josh for this update.
it does not clear to me if maven build is getting this update or not.
I just sync the repos, build and all is ok, but maybe because there's no
GCC update in mvn?
thanks
2016-12-17 23:54 GMT+01:00 Alex Harui <ah...@adobe.com>:
> I don't think closure compiler is involved in a library build.
>
> Sent from my LG G3, an AT&T 4G LTE smartphone
>
> ------ Original message------
> From: Christofer Dutz
> Date: Sat, Dec 17, 2016 2:21 PM
> To: dev@flex.apache.org;
> Subject:AW: [FlexJS] Updated Closure compiler from v20151015 to v20161201
>
> It doesn't report errors, because I had to disable that because there we
> always closure errors in normal execution :-(
>
>
>
>
>
> Von meinem Samsung Galaxy Smartphone gesendet.
>
>
> -------- Ursprüngliche Nachricht --------
> Von: Alex Harui <ah...@adobe.com>
> Datum: 17.12.16 21:08 (GMT+01:00)
> An: joshtynjala@gmail.com, dev@flex.apache.org
> Betreff: Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
>
> For some reason the maven build did not report failure. Errors were in
> the console log. I plan to look into that tonight.
>
> The ci maven build is failing in the distribution step. Hopefully Chris
> can help.
>
> Sent from my LG G3, an AT&T 4G LTE smartphone
>
> ------ Original message------
> From: Josh Tynjala
> Date: Sat, Dec 17, 2016 8:15 AM
> To: dev@flex.apache.org;
> Subject:Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
>
> Oh, right, I forgot that Maven doesn't use the compiler's config files, for
> some reason. I wish it would so that we could keep the builds in sync
> easier. Oh well. Thanks, Alex!
>
> - Josh
>
> On Dec 16, 2016 10:41 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
> > Thanks Josh! I had to make one fix for Maven in flex-typedefs, but your
> > changes build with Ant and Maven locally for me.
> >
> > -Alex
> >
> > On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
> >
> > >Hey folks,
> > >
> > >I updated flex-falcon to use a newer build of Closure compiler,
> > >specifically v20161201. This also required an update of the Guava
> > >dependency from v17.0 to v20.0. I have made the required changes to the
> > >dependencies for both Ant and Maven builds.
> > >
> > >An update to Closure compiler means that we have the latest features and
> > >bug fixes from Google for optimizing our JS release builds. For
> instance,
> > >one new feature that prompted my desire to update should allow us to
> > >improve JS source maps for release builds (to step through the original
> > >ActionScript instead of the generated js-debug JavaScript). It also
> means
> > >updated externs with the newest JavaScript browser APIs becoming exposed
> > >to
> > >ActionScript. Finally, the v20151015 build is getting to be over a year
> > >old
> > >now, and the longer we wait to update, the harder it will become!
> > >
> > >This change also affected the flex-typedefs and flex-asjs repositories a
> > >bit. I had to make a few tweaks here and there because Closure compiler
> or
> > >the externs became a little more strict, and some APIs were renamed. I
> > >think I got everything running properly because the DataBindingExample
> > >works correctly, but I encourage you to test more examples to be sure
> that
> > >I didn't miss anything.
> > >
> > >If you're using the Ant build, you need to be sure to wipe before
> building
> > >each of the repositories after you pull the latest changes. Be sure to
> > >pull
> > >from all three repos! This will ensure that the new dependencies are
> > >downloaded to replace the old ones, and everything will be in sync.
> > >
> > >flex-falcon:
> > >ant wipe-all
> > >
> > >flex-typedefs:
> > >ant wipe
> > >
> > >flex-asjs:
> > >ant super-clean
> > >
> > >I ran all of these on the Ant CI server, and I'll make tweaks as needed
> if
> > >anything appears to break.
> > >
> > >- Josh
> >
> >
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: AW: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Hi, Thanks Josh for this update.
it does not clear to me if maven build is getting this update or not.
I just sync the repos, build and all is ok, but maybe because there's no
GCC update in mvn?
thanks
2016-12-17 23:54 GMT+01:00 Alex Harui <ah...@adobe.com>:
> I don't think closure compiler is involved in a library build.
>
> Sent from my LG G3, an AT&T 4G LTE smartphone
>
> ------ Original message------
> From: Christofer Dutz
> Date: Sat, Dec 17, 2016 2:21 PM
> To: dev@flex.apache.org;
> Subject:AW: [FlexJS] Updated Closure compiler from v20151015 to v20161201
>
> It doesn't report errors, because I had to disable that because there we
> always closure errors in normal execution :-(
>
>
>
>
>
> Von meinem Samsung Galaxy Smartphone gesendet.
>
>
> -------- Ursprüngliche Nachricht --------
> Von: Alex Harui <ah...@adobe.com>
> Datum: 17.12.16 21:08 (GMT+01:00)
> An: joshtynjala@gmail.com, dev@flex.apache.org
> Betreff: Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
>
> For some reason the maven build did not report failure. Errors were in
> the console log. I plan to look into that tonight.
>
> The ci maven build is failing in the distribution step. Hopefully Chris
> can help.
>
> Sent from my LG G3, an AT&T 4G LTE smartphone
>
> ------ Original message------
> From: Josh Tynjala
> Date: Sat, Dec 17, 2016 8:15 AM
> To: dev@flex.apache.org;
> Subject:Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
>
> Oh, right, I forgot that Maven doesn't use the compiler's config files, for
> some reason. I wish it would so that we could keep the builds in sync
> easier. Oh well. Thanks, Alex!
>
> - Josh
>
> On Dec 16, 2016 10:41 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
> > Thanks Josh! I had to make one fix for Maven in flex-typedefs, but your
> > changes build with Ant and Maven locally for me.
> >
> > -Alex
> >
> > On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
> >
> > >Hey folks,
> > >
> > >I updated flex-falcon to use a newer build of Closure compiler,
> > >specifically v20161201. This also required an update of the Guava
> > >dependency from v17.0 to v20.0. I have made the required changes to the
> > >dependencies for both Ant and Maven builds.
> > >
> > >An update to Closure compiler means that we have the latest features and
> > >bug fixes from Google for optimizing our JS release builds. For
> instance,
> > >one new feature that prompted my desire to update should allow us to
> > >improve JS source maps for release builds (to step through the original
> > >ActionScript instead of the generated js-debug JavaScript). It also
> means
> > >updated externs with the newest JavaScript browser APIs becoming exposed
> > >to
> > >ActionScript. Finally, the v20151015 build is getting to be over a year
> > >old
> > >now, and the longer we wait to update, the harder it will become!
> > >
> > >This change also affected the flex-typedefs and flex-asjs repositories a
> > >bit. I had to make a few tweaks here and there because Closure compiler
> or
> > >the externs became a little more strict, and some APIs were renamed. I
> > >think I got everything running properly because the DataBindingExample
> > >works correctly, but I encourage you to test more examples to be sure
> that
> > >I didn't miss anything.
> > >
> > >If you're using the Ant build, you need to be sure to wipe before
> building
> > >each of the repositories after you pull the latest changes. Be sure to
> > >pull
> > >from all three repos! This will ensure that the new dependencies are
> > >downloaded to replace the old ones, and everything will be in sync.
> > >
> > >flex-falcon:
> > >ant wipe-all
> > >
> > >flex-typedefs:
> > >ant wipe
> > >
> > >flex-asjs:
> > >ant super-clean
> > >
> > >I ran all of these on the Ant CI server, and I'll make tweaks as needed
> if
> > >anything appears to break.
> > >
> > >- Josh
> >
> >
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: AW: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by Alex Harui <ah...@adobe.com>.
I don't think closure compiler is involved in a library build.
Sent from my LG G3, an AT&T 4G LTE smartphone
------ Original message------
From: Christofer Dutz
Date: Sat, Dec 17, 2016 2:21 PM
To: dev@flex.apache.org;
Subject:AW: [FlexJS] Updated Closure compiler from v20151015 to v20161201
It doesn't report errors, because I had to disable that because there we always closure errors in normal execution :-(
Von meinem Samsung Galaxy Smartphone gesendet.
-------- Ursprüngliche Nachricht --------
Von: Alex Harui <ah...@adobe.com>
Datum: 17.12.16 21:08 (GMT+01:00)
An: joshtynjala@gmail.com, dev@flex.apache.org
Betreff: Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
For some reason the maven build did not report failure. Errors were in the console log. I plan to look into that tonight.
The ci maven build is failing in the distribution step. Hopefully Chris can help.
Sent from my LG G3, an AT&T 4G LTE smartphone
------ Original message------
From: Josh Tynjala
Date: Sat, Dec 17, 2016 8:15 AM
To: dev@flex.apache.org;
Subject:Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Oh, right, I forgot that Maven doesn't use the compiler's config files, for
some reason. I wish it would so that we could keep the builds in sync
easier. Oh well. Thanks, Alex!
- Josh
On Dec 16, 2016 10:41 PM, "Alex Harui" <ah...@adobe.com> wrote:
> Thanks Josh! I had to make one fix for Maven in flex-typedefs, but your
> changes build with Ant and Maven locally for me.
>
> -Alex
>
> On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
>
> >Hey folks,
> >
> >I updated flex-falcon to use a newer build of Closure compiler,
> >specifically v20161201. This also required an update of the Guava
> >dependency from v17.0 to v20.0. I have made the required changes to the
> >dependencies for both Ant and Maven builds.
> >
> >An update to Closure compiler means that we have the latest features and
> >bug fixes from Google for optimizing our JS release builds. For instance,
> >one new feature that prompted my desire to update should allow us to
> >improve JS source maps for release builds (to step through the original
> >ActionScript instead of the generated js-debug JavaScript). It also means
> >updated externs with the newest JavaScript browser APIs becoming exposed
> >to
> >ActionScript. Finally, the v20151015 build is getting to be over a year
> >old
> >now, and the longer we wait to update, the harder it will become!
> >
> >This change also affected the flex-typedefs and flex-asjs repositories a
> >bit. I had to make a few tweaks here and there because Closure compiler or
> >the externs became a little more strict, and some APIs were renamed. I
> >think I got everything running properly because the DataBindingExample
> >works correctly, but I encourage you to test more examples to be sure that
> >I didn't miss anything.
> >
> >If you're using the Ant build, you need to be sure to wipe before building
> >each of the repositories after you pull the latest changes. Be sure to
> >pull
> >from all three repos! This will ensure that the new dependencies are
> >downloaded to replace the old ones, and everything will be in sync.
> >
> >flex-falcon:
> >ant wipe-all
> >
> >flex-typedefs:
> >ant wipe
> >
> >flex-asjs:
> >ant super-clean
> >
> >I ran all of these on the Ant CI server, and I'll make tweaks as needed if
> >anything appears to break.
> >
> >- Josh
>
>
AW: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by Christofer Dutz <ch...@c-ware.de>.
It doesn't report errors, because I had to disable that because there we always closure errors in normal execution :-(
Von meinem Samsung Galaxy Smartphone gesendet.
-------- Ursprüngliche Nachricht --------
Von: Alex Harui <ah...@adobe.com>
Datum: 17.12.16 21:08 (GMT+01:00)
An: joshtynjala@gmail.com, dev@flex.apache.org
Betreff: Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
For some reason the maven build did not report failure. Errors were in the console log. I plan to look into that tonight.
The ci maven build is failing in the distribution step. Hopefully Chris can help.
Sent from my LG G3, an AT&T 4G LTE smartphone
------ Original message------
From: Josh Tynjala
Date: Sat, Dec 17, 2016 8:15 AM
To: dev@flex.apache.org;
Subject:Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Oh, right, I forgot that Maven doesn't use the compiler's config files, for
some reason. I wish it would so that we could keep the builds in sync
easier. Oh well. Thanks, Alex!
- Josh
On Dec 16, 2016 10:41 PM, "Alex Harui" <ah...@adobe.com> wrote:
> Thanks Josh! I had to make one fix for Maven in flex-typedefs, but your
> changes build with Ant and Maven locally for me.
>
> -Alex
>
> On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
>
> >Hey folks,
> >
> >I updated flex-falcon to use a newer build of Closure compiler,
> >specifically v20161201. This also required an update of the Guava
> >dependency from v17.0 to v20.0. I have made the required changes to the
> >dependencies for both Ant and Maven builds.
> >
> >An update to Closure compiler means that we have the latest features and
> >bug fixes from Google for optimizing our JS release builds. For instance,
> >one new feature that prompted my desire to update should allow us to
> >improve JS source maps for release builds (to step through the original
> >ActionScript instead of the generated js-debug JavaScript). It also means
> >updated externs with the newest JavaScript browser APIs becoming exposed
> >to
> >ActionScript. Finally, the v20151015 build is getting to be over a year
> >old
> >now, and the longer we wait to update, the harder it will become!
> >
> >This change also affected the flex-typedefs and flex-asjs repositories a
> >bit. I had to make a few tweaks here and there because Closure compiler or
> >the externs became a little more strict, and some APIs were renamed. I
> >think I got everything running properly because the DataBindingExample
> >works correctly, but I encourage you to test more examples to be sure that
> >I didn't miss anything.
> >
> >If you're using the Ant build, you need to be sure to wipe before building
> >each of the repositories after you pull the latest changes. Be sure to
> >pull
> >from all three repos! This will ensure that the new dependencies are
> >downloaded to replace the old ones, and everything will be in sync.
> >
> >flex-falcon:
> >ant wipe-all
> >
> >flex-typedefs:
> >ant wipe
> >
> >flex-asjs:
> >ant super-clean
> >
> >I ran all of these on the Ant CI server, and I'll make tweaks as needed if
> >anything appears to break.
> >
> >- Josh
>
>
Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by Josh Tynjala <jo...@gmail.com>.
Hi Daniel,
Please refer to this page for how to unsubscribe from the Apache Flex
mailing lists:
http://flex.apache.org/community-mailinglists.html
- Josh
On Mon, Dec 19, 2016 at 8:57 AM, Daniel Harfleet <dh...@gmail.com>
wrote:
> Unsubscribe
>
> Sent from my iPhone
>
> > On 19 Dec 2016, at 16:37, Josh Tynjala <jo...@gmail.com> wrote:
> >
> > Thanks, Om!
> >
> > - Josh
> >
> > On Sun, Dec 18, 2016 at 10:59 PM, OmPrakash Muppirala <
> bigosmallm@gmail.com>
> > wrote:
> >
> >> On Sat, Dec 17, 2016 at 3:01 PM, Josh Tynjala <jo...@gmail.com>
> >> wrote:
> >>
> >>> If the NPM version downloads Closure compiler, it should switch to
> >>> version v20161201. Similarly, Guava should be updated to version 20.0.
> I
> >>> might be wrong, but I think we distribute these with the binary, so you
> >>> might not need to change anything.
> >>
> >> FlexJS npm installer does indeed download these two files. I've gone
> >> ahead and updated them.
> >>
> >> Thanks,
> >> Om
> >>
> >>
> >>>
> >>> - Josh
> >>>
> >>> On Dec 17, 2016 1:06 PM, "OmPrakash Muppirala" <bi...@gmail.com>
> >>> wrote:
> >>>
> >>>> Josh, will this affect the npm flexjs installer? What are the
> changes I
> >>>> need to make?
> >>>>
> >>>> Thanks,
> >>>> Om
> >>>>
> >>>>> On Sat, Dec 17, 2016 at 9:40 AM, Alex Harui <ah...@adobe.com>
> wrote:
> >>>>>
> >>>>> For some reason the maven build did not report failure. Errors were
> in
> >>>>> the console log. I plan to look into that tonight.
> >>>>>
> >>>>> The ci maven build is failing in the distribution step. Hopefully
> >>>>> Chris can help.
> >>>>>
> >>>>> Sent from my LG G3, an AT&T 4G LTE smartphone
> >>>>>
> >>>>> ------ Original message------
> >>>>> From: Josh Tynjala
> >>>>> Date: Sat, Dec 17, 2016 8:15 AM
> >>>>> To: dev@flex.apache.org;
> >>>>> Subject:Re: [FlexJS] Updated Closure compiler from v20151015 to
> >>>>> v20161201
> >>>>>
> >>>>> Oh, right, I forgot that Maven doesn't use the compiler's config
> files,
> >>>>> for
> >>>>> some reason. I wish it would so that we could keep the builds in sync
> >>>>> easier. Oh well. Thanks, Alex!
> >>>>>
> >>>>> - Josh
> >>>>>
> >>>>>> On Dec 16, 2016 10:41 PM, "Alex Harui" <ah...@adobe.com> wrote:
> >>>>>>
> >>>>>> Thanks Josh! I had to make one fix for Maven in flex-typedefs, but
> >>>>> your
> >>>>>> changes build with Ant and Maven locally for me.
> >>>>>>
> >>>>>> -Alex
> >>>>>>
> >>>>>>> On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com>
> wrote:
> >>>>>>>
> >>>>>>> Hey folks,
> >>>>>>>
> >>>>>>> I updated flex-falcon to use a newer build of Closure compiler,
> >>>>>>> specifically v20161201. This also required an update of the Guava
> >>>>>>> dependency from v17.0 to v20.0. I have made the required changes to
> >>>>> the
> >>>>>>> dependencies for both Ant and Maven builds.
> >>>>>>>
> >>>>>>> An update to Closure compiler means that we have the latest
> features
> >>>>> and
> >>>>>>> bug fixes from Google for optimizing our JS release builds. For
> >>>>> instance,
> >>>>>>> one new feature that prompted my desire to update should allow us
> to
> >>>>>>> improve JS source maps for release builds (to step through the
> >>>>> original
> >>>>>>> ActionScript instead of the generated js-debug JavaScript). It also
> >>>>> means
> >>>>>>> updated externs with the newest JavaScript browser APIs becoming
> >>>>> exposed
> >>>>>>> to
> >>>>>>> ActionScript. Finally, the v20151015 build is getting to be over a
> >>>>> year
> >>>>>>> old
> >>>>>>> now, and the longer we wait to update, the harder it will become!
> >>>>>>>
> >>>>>>> This change also affected the flex-typedefs and flex-asjs
> >>>>> repositories a
> >>>>>>> bit. I had to make a few tweaks here and there because Closure
> >>>>> compiler or
> >>>>>>> the externs became a little more strict, and some APIs were
> renamed.
> >>>>> I
> >>>>>>> think I got everything running properly because the
> >>>>> DataBindingExample
> >>>>>>> works correctly, but I encourage you to test more examples to be
> >>>>> sure that
> >>>>>>> I didn't miss anything.
> >>>>>>>
> >>>>>>> If you're using the Ant build, you need to be sure to wipe before
> >>>>> building
> >>>>>>> each of the repositories after you pull the latest changes. Be sure
> >>>>> to
> >>>>>>> pull
> >>>>>>> from all three repos! This will ensure that the new dependencies
> are
> >>>>>>> downloaded to replace the old ones, and everything will be in sync.
> >>>>>>>
> >>>>>>> flex-falcon:
> >>>>>>> ant wipe-all
> >>>>>>>
> >>>>>>> flex-typedefs:
> >>>>>>> ant wipe
> >>>>>>>
> >>>>>>> flex-asjs:
> >>>>>>> ant super-clean
> >>>>>>>
> >>>>>>> I ran all of these on the Ant CI server, and I'll make tweaks as
> >>>>> needed if
> >>>>>>> anything appears to break.
> >>>>>>>
> >>>>>>> - Josh
> >>
>
Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by Daniel Harfleet <dh...@gmail.com>.
Unsubscribe
Sent from my iPhone
> On 19 Dec 2016, at 16:37, Josh Tynjala <jo...@gmail.com> wrote:
>
> Thanks, Om!
>
> - Josh
>
> On Sun, Dec 18, 2016 at 10:59 PM, OmPrakash Muppirala <bi...@gmail.com>
> wrote:
>
>> On Sat, Dec 17, 2016 at 3:01 PM, Josh Tynjala <jo...@gmail.com>
>> wrote:
>>
>>> If the NPM version downloads Closure compiler, it should switch to
>>> version v20161201. Similarly, Guava should be updated to version 20.0. I
>>> might be wrong, but I think we distribute these with the binary, so you
>>> might not need to change anything.
>>
>> FlexJS npm installer does indeed download these two files. I've gone
>> ahead and updated them.
>>
>> Thanks,
>> Om
>>
>>
>>>
>>> - Josh
>>>
>>> On Dec 17, 2016 1:06 PM, "OmPrakash Muppirala" <bi...@gmail.com>
>>> wrote:
>>>
>>>> Josh, will this affect the npm flexjs installer? What are the changes I
>>>> need to make?
>>>>
>>>> Thanks,
>>>> Om
>>>>
>>>>> On Sat, Dec 17, 2016 at 9:40 AM, Alex Harui <ah...@adobe.com> wrote:
>>>>>
>>>>> For some reason the maven build did not report failure. Errors were in
>>>>> the console log. I plan to look into that tonight.
>>>>>
>>>>> The ci maven build is failing in the distribution step. Hopefully
>>>>> Chris can help.
>>>>>
>>>>> Sent from my LG G3, an AT&T 4G LTE smartphone
>>>>>
>>>>> ------ Original message------
>>>>> From: Josh Tynjala
>>>>> Date: Sat, Dec 17, 2016 8:15 AM
>>>>> To: dev@flex.apache.org;
>>>>> Subject:Re: [FlexJS] Updated Closure compiler from v20151015 to
>>>>> v20161201
>>>>>
>>>>> Oh, right, I forgot that Maven doesn't use the compiler's config files,
>>>>> for
>>>>> some reason. I wish it would so that we could keep the builds in sync
>>>>> easier. Oh well. Thanks, Alex!
>>>>>
>>>>> - Josh
>>>>>
>>>>>> On Dec 16, 2016 10:41 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>>>>>
>>>>>> Thanks Josh! I had to make one fix for Maven in flex-typedefs, but
>>>>> your
>>>>>> changes build with Ant and Maven locally for me.
>>>>>>
>>>>>> -Alex
>>>>>>
>>>>>>> On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
>>>>>>>
>>>>>>> Hey folks,
>>>>>>>
>>>>>>> I updated flex-falcon to use a newer build of Closure compiler,
>>>>>>> specifically v20161201. This also required an update of the Guava
>>>>>>> dependency from v17.0 to v20.0. I have made the required changes to
>>>>> the
>>>>>>> dependencies for both Ant and Maven builds.
>>>>>>>
>>>>>>> An update to Closure compiler means that we have the latest features
>>>>> and
>>>>>>> bug fixes from Google for optimizing our JS release builds. For
>>>>> instance,
>>>>>>> one new feature that prompted my desire to update should allow us to
>>>>>>> improve JS source maps for release builds (to step through the
>>>>> original
>>>>>>> ActionScript instead of the generated js-debug JavaScript). It also
>>>>> means
>>>>>>> updated externs with the newest JavaScript browser APIs becoming
>>>>> exposed
>>>>>>> to
>>>>>>> ActionScript. Finally, the v20151015 build is getting to be over a
>>>>> year
>>>>>>> old
>>>>>>> now, and the longer we wait to update, the harder it will become!
>>>>>>>
>>>>>>> This change also affected the flex-typedefs and flex-asjs
>>>>> repositories a
>>>>>>> bit. I had to make a few tweaks here and there because Closure
>>>>> compiler or
>>>>>>> the externs became a little more strict, and some APIs were renamed.
>>>>> I
>>>>>>> think I got everything running properly because the
>>>>> DataBindingExample
>>>>>>> works correctly, but I encourage you to test more examples to be
>>>>> sure that
>>>>>>> I didn't miss anything.
>>>>>>>
>>>>>>> If you're using the Ant build, you need to be sure to wipe before
>>>>> building
>>>>>>> each of the repositories after you pull the latest changes. Be sure
>>>>> to
>>>>>>> pull
>>>>>>> from all three repos! This will ensure that the new dependencies are
>>>>>>> downloaded to replace the old ones, and everything will be in sync.
>>>>>>>
>>>>>>> flex-falcon:
>>>>>>> ant wipe-all
>>>>>>>
>>>>>>> flex-typedefs:
>>>>>>> ant wipe
>>>>>>>
>>>>>>> flex-asjs:
>>>>>>> ant super-clean
>>>>>>>
>>>>>>> I ran all of these on the Ant CI server, and I'll make tweaks as
>>>>> needed if
>>>>>>> anything appears to break.
>>>>>>>
>>>>>>> - Josh
>>
Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by Josh Tynjala <jo...@gmail.com>.
Thanks, Om!
- Josh
On Sun, Dec 18, 2016 at 10:59 PM, OmPrakash Muppirala <bi...@gmail.com>
wrote:
> On Sat, Dec 17, 2016 at 3:01 PM, Josh Tynjala <jo...@gmail.com>
> wrote:
>
>> If the NPM version downloads Closure compiler, it should switch to
>> version v20161201. Similarly, Guava should be updated to version 20.0. I
>> might be wrong, but I think we distribute these with the binary, so you
>> might not need to change anything.
>>
>
> FlexJS npm installer does indeed download these two files. I've gone
> ahead and updated them.
>
> Thanks,
> Om
>
>
>>
>> - Josh
>>
>> On Dec 17, 2016 1:06 PM, "OmPrakash Muppirala" <bi...@gmail.com>
>> wrote:
>>
>>> Josh, will this affect the npm flexjs installer? What are the changes I
>>> need to make?
>>>
>>> Thanks,
>>> Om
>>>
>>> On Sat, Dec 17, 2016 at 9:40 AM, Alex Harui <ah...@adobe.com> wrote:
>>>
>>>> For some reason the maven build did not report failure. Errors were in
>>>> the console log. I plan to look into that tonight.
>>>>
>>>> The ci maven build is failing in the distribution step. Hopefully
>>>> Chris can help.
>>>>
>>>> Sent from my LG G3, an AT&T 4G LTE smartphone
>>>>
>>>> ------ Original message------
>>>> From: Josh Tynjala
>>>> Date: Sat, Dec 17, 2016 8:15 AM
>>>> To: dev@flex.apache.org;
>>>> Subject:Re: [FlexJS] Updated Closure compiler from v20151015 to
>>>> v20161201
>>>>
>>>> Oh, right, I forgot that Maven doesn't use the compiler's config files,
>>>> for
>>>> some reason. I wish it would so that we could keep the builds in sync
>>>> easier. Oh well. Thanks, Alex!
>>>>
>>>> - Josh
>>>>
>>>> On Dec 16, 2016 10:41 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>>>
>>>> > Thanks Josh! I had to make one fix for Maven in flex-typedefs, but
>>>> your
>>>> > changes build with Ant and Maven locally for me.
>>>> >
>>>> > -Alex
>>>> >
>>>> > On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
>>>> >
>>>> > >Hey folks,
>>>> > >
>>>> > >I updated flex-falcon to use a newer build of Closure compiler,
>>>> > >specifically v20161201. This also required an update of the Guava
>>>> > >dependency from v17.0 to v20.0. I have made the required changes to
>>>> the
>>>> > >dependencies for both Ant and Maven builds.
>>>> > >
>>>> > >An update to Closure compiler means that we have the latest features
>>>> and
>>>> > >bug fixes from Google for optimizing our JS release builds. For
>>>> instance,
>>>> > >one new feature that prompted my desire to update should allow us to
>>>> > >improve JS source maps for release builds (to step through the
>>>> original
>>>> > >ActionScript instead of the generated js-debug JavaScript). It also
>>>> means
>>>> > >updated externs with the newest JavaScript browser APIs becoming
>>>> exposed
>>>> > >to
>>>> > >ActionScript. Finally, the v20151015 build is getting to be over a
>>>> year
>>>> > >old
>>>> > >now, and the longer we wait to update, the harder it will become!
>>>> > >
>>>> > >This change also affected the flex-typedefs and flex-asjs
>>>> repositories a
>>>> > >bit. I had to make a few tweaks here and there because Closure
>>>> compiler or
>>>> > >the externs became a little more strict, and some APIs were renamed.
>>>> I
>>>> > >think I got everything running properly because the
>>>> DataBindingExample
>>>> > >works correctly, but I encourage you to test more examples to be
>>>> sure that
>>>> > >I didn't miss anything.
>>>> > >
>>>> > >If you're using the Ant build, you need to be sure to wipe before
>>>> building
>>>> > >each of the repositories after you pull the latest changes. Be sure
>>>> to
>>>> > >pull
>>>> > >from all three repos! This will ensure that the new dependencies are
>>>> > >downloaded to replace the old ones, and everything will be in sync.
>>>> > >
>>>> > >flex-falcon:
>>>> > >ant wipe-all
>>>> > >
>>>> > >flex-typedefs:
>>>> > >ant wipe
>>>> > >
>>>> > >flex-asjs:
>>>> > >ant super-clean
>>>> > >
>>>> > >I ran all of these on the Ant CI server, and I'll make tweaks as
>>>> needed if
>>>> > >anything appears to break.
>>>> > >
>>>> > >- Josh
>>>> >
>>>> >
>>>>
>>>
>>>
>
Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by OmPrakash Muppirala <bi...@gmail.com>.
On Sat, Dec 17, 2016 at 3:01 PM, Josh Tynjala <jo...@gmail.com> wrote:
> If the NPM version downloads Closure compiler, it should switch to version
> v20161201. Similarly, Guava should be updated to version 20.0. I might be
> wrong, but I think we distribute these with the binary, so you might not
> need to change anything.
>
FlexJS npm installer does indeed download these two files. I've gone ahead
and updated them.
Thanks,
Om
>
> - Josh
>
> On Dec 17, 2016 1:06 PM, "OmPrakash Muppirala" <bi...@gmail.com>
> wrote:
>
>> Josh, will this affect the npm flexjs installer? What are the changes I
>> need to make?
>>
>> Thanks,
>> Om
>>
>> On Sat, Dec 17, 2016 at 9:40 AM, Alex Harui <ah...@adobe.com> wrote:
>>
>>> For some reason the maven build did not report failure. Errors were in
>>> the console log. I plan to look into that tonight.
>>>
>>> The ci maven build is failing in the distribution step. Hopefully Chris
>>> can help.
>>>
>>> Sent from my LG G3, an AT&T 4G LTE smartphone
>>>
>>> ------ Original message------
>>> From: Josh Tynjala
>>> Date: Sat, Dec 17, 2016 8:15 AM
>>> To: dev@flex.apache.org;
>>> Subject:Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
>>>
>>> Oh, right, I forgot that Maven doesn't use the compiler's config files,
>>> for
>>> some reason. I wish it would so that we could keep the builds in sync
>>> easier. Oh well. Thanks, Alex!
>>>
>>> - Josh
>>>
>>> On Dec 16, 2016 10:41 PM, "Alex Harui" <ah...@adobe.com> wrote:
>>>
>>> > Thanks Josh! I had to make one fix for Maven in flex-typedefs, but
>>> your
>>> > changes build with Ant and Maven locally for me.
>>> >
>>> > -Alex
>>> >
>>> > On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
>>> >
>>> > >Hey folks,
>>> > >
>>> > >I updated flex-falcon to use a newer build of Closure compiler,
>>> > >specifically v20161201. This also required an update of the Guava
>>> > >dependency from v17.0 to v20.0. I have made the required changes to
>>> the
>>> > >dependencies for both Ant and Maven builds.
>>> > >
>>> > >An update to Closure compiler means that we have the latest features
>>> and
>>> > >bug fixes from Google for optimizing our JS release builds. For
>>> instance,
>>> > >one new feature that prompted my desire to update should allow us to
>>> > >improve JS source maps for release builds (to step through the
>>> original
>>> > >ActionScript instead of the generated js-debug JavaScript). It also
>>> means
>>> > >updated externs with the newest JavaScript browser APIs becoming
>>> exposed
>>> > >to
>>> > >ActionScript. Finally, the v20151015 build is getting to be over a
>>> year
>>> > >old
>>> > >now, and the longer we wait to update, the harder it will become!
>>> > >
>>> > >This change also affected the flex-typedefs and flex-asjs
>>> repositories a
>>> > >bit. I had to make a few tweaks here and there because Closure
>>> compiler or
>>> > >the externs became a little more strict, and some APIs were renamed. I
>>> > >think I got everything running properly because the DataBindingExample
>>> > >works correctly, but I encourage you to test more examples to be sure
>>> that
>>> > >I didn't miss anything.
>>> > >
>>> > >If you're using the Ant build, you need to be sure to wipe before
>>> building
>>> > >each of the repositories after you pull the latest changes. Be sure to
>>> > >pull
>>> > >from all three repos! This will ensure that the new dependencies are
>>> > >downloaded to replace the old ones, and everything will be in sync.
>>> > >
>>> > >flex-falcon:
>>> > >ant wipe-all
>>> > >
>>> > >flex-typedefs:
>>> > >ant wipe
>>> > >
>>> > >flex-asjs:
>>> > >ant super-clean
>>> > >
>>> > >I ran all of these on the Ant CI server, and I'll make tweaks as
>>> needed if
>>> > >anything appears to break.
>>> > >
>>> > >- Josh
>>> >
>>> >
>>>
>>
>>
Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by OmPrakash Muppirala <bi...@gmail.com>.
Josh, will this affect the npm flexjs installer? What are the changes I
need to make?
Thanks,
Om
On Sat, Dec 17, 2016 at 9:40 AM, Alex Harui <ah...@adobe.com> wrote:
> For some reason the maven build did not report failure. Errors were in
> the console log. I plan to look into that tonight.
>
> The ci maven build is failing in the distribution step. Hopefully Chris
> can help.
>
> Sent from my LG G3, an AT&T 4G LTE smartphone
>
> ------ Original message------
> From: Josh Tynjala
> Date: Sat, Dec 17, 2016 8:15 AM
> To: dev@flex.apache.org;
> Subject:Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
>
> Oh, right, I forgot that Maven doesn't use the compiler's config files, for
> some reason. I wish it would so that we could keep the builds in sync
> easier. Oh well. Thanks, Alex!
>
> - Josh
>
> On Dec 16, 2016 10:41 PM, "Alex Harui" <ah...@adobe.com> wrote:
>
> > Thanks Josh! I had to make one fix for Maven in flex-typedefs, but your
> > changes build with Ant and Maven locally for me.
> >
> > -Alex
> >
> > On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
> >
> > >Hey folks,
> > >
> > >I updated flex-falcon to use a newer build of Closure compiler,
> > >specifically v20161201. This also required an update of the Guava
> > >dependency from v17.0 to v20.0. I have made the required changes to the
> > >dependencies for both Ant and Maven builds.
> > >
> > >An update to Closure compiler means that we have the latest features and
> > >bug fixes from Google for optimizing our JS release builds. For
> instance,
> > >one new feature that prompted my desire to update should allow us to
> > >improve JS source maps for release builds (to step through the original
> > >ActionScript instead of the generated js-debug JavaScript). It also
> means
> > >updated externs with the newest JavaScript browser APIs becoming exposed
> > >to
> > >ActionScript. Finally, the v20151015 build is getting to be over a year
> > >old
> > >now, and the longer we wait to update, the harder it will become!
> > >
> > >This change also affected the flex-typedefs and flex-asjs repositories a
> > >bit. I had to make a few tweaks here and there because Closure compiler
> or
> > >the externs became a little more strict, and some APIs were renamed. I
> > >think I got everything running properly because the DataBindingExample
> > >works correctly, but I encourage you to test more examples to be sure
> that
> > >I didn't miss anything.
> > >
> > >If you're using the Ant build, you need to be sure to wipe before
> building
> > >each of the repositories after you pull the latest changes. Be sure to
> > >pull
> > >from all three repos! This will ensure that the new dependencies are
> > >downloaded to replace the old ones, and everything will be in sync.
> > >
> > >flex-falcon:
> > >ant wipe-all
> > >
> > >flex-typedefs:
> > >ant wipe
> > >
> > >flex-asjs:
> > >ant super-clean
> > >
> > >I ran all of these on the Ant CI server, and I'll make tweaks as needed
> if
> > >anything appears to break.
> > >
> > >- Josh
> >
> >
>
Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by Alex Harui <ah...@adobe.com>.
For some reason the maven build did not report failure. Errors were in the console log. I plan to look into that tonight.
The ci maven build is failing in the distribution step. Hopefully Chris can help.
Sent from my LG G3, an AT&T 4G LTE smartphone
------ Original message------
From: Josh Tynjala
Date: Sat, Dec 17, 2016 8:15 AM
To: dev@flex.apache.org;
Subject:Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Oh, right, I forgot that Maven doesn't use the compiler's config files, for
some reason. I wish it would so that we could keep the builds in sync
easier. Oh well. Thanks, Alex!
- Josh
On Dec 16, 2016 10:41 PM, "Alex Harui" <ah...@adobe.com> wrote:
> Thanks Josh! I had to make one fix for Maven in flex-typedefs, but your
> changes build with Ant and Maven locally for me.
>
> -Alex
>
> On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
>
> >Hey folks,
> >
> >I updated flex-falcon to use a newer build of Closure compiler,
> >specifically v20161201. This also required an update of the Guava
> >dependency from v17.0 to v20.0. I have made the required changes to the
> >dependencies for both Ant and Maven builds.
> >
> >An update to Closure compiler means that we have the latest features and
> >bug fixes from Google for optimizing our JS release builds. For instance,
> >one new feature that prompted my desire to update should allow us to
> >improve JS source maps for release builds (to step through the original
> >ActionScript instead of the generated js-debug JavaScript). It also means
> >updated externs with the newest JavaScript browser APIs becoming exposed
> >to
> >ActionScript. Finally, the v20151015 build is getting to be over a year
> >old
> >now, and the longer we wait to update, the harder it will become!
> >
> >This change also affected the flex-typedefs and flex-asjs repositories a
> >bit. I had to make a few tweaks here and there because Closure compiler or
> >the externs became a little more strict, and some APIs were renamed. I
> >think I got everything running properly because the DataBindingExample
> >works correctly, but I encourage you to test more examples to be sure that
> >I didn't miss anything.
> >
> >If you're using the Ant build, you need to be sure to wipe before building
> >each of the repositories after you pull the latest changes. Be sure to
> >pull
> >from all three repos! This will ensure that the new dependencies are
> >downloaded to replace the old ones, and everything will be in sync.
> >
> >flex-falcon:
> >ant wipe-all
> >
> >flex-typedefs:
> >ant wipe
> >
> >flex-asjs:
> >ant super-clean
> >
> >I ran all of these on the Ant CI server, and I'll make tweaks as needed if
> >anything appears to break.
> >
> >- Josh
>
>
Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by Josh Tynjala <jo...@gmail.com>.
Oh, right, I forgot that Maven doesn't use the compiler's config files, for
some reason. I wish it would so that we could keep the builds in sync
easier. Oh well. Thanks, Alex!
- Josh
On Dec 16, 2016 10:41 PM, "Alex Harui" <ah...@adobe.com> wrote:
> Thanks Josh! I had to make one fix for Maven in flex-typedefs, but your
> changes build with Ant and Maven locally for me.
>
> -Alex
>
> On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
>
> >Hey folks,
> >
> >I updated flex-falcon to use a newer build of Closure compiler,
> >specifically v20161201. This also required an update of the Guava
> >dependency from v17.0 to v20.0. I have made the required changes to the
> >dependencies for both Ant and Maven builds.
> >
> >An update to Closure compiler means that we have the latest features and
> >bug fixes from Google for optimizing our JS release builds. For instance,
> >one new feature that prompted my desire to update should allow us to
> >improve JS source maps for release builds (to step through the original
> >ActionScript instead of the generated js-debug JavaScript). It also means
> >updated externs with the newest JavaScript browser APIs becoming exposed
> >to
> >ActionScript. Finally, the v20151015 build is getting to be over a year
> >old
> >now, and the longer we wait to update, the harder it will become!
> >
> >This change also affected the flex-typedefs and flex-asjs repositories a
> >bit. I had to make a few tweaks here and there because Closure compiler or
> >the externs became a little more strict, and some APIs were renamed. I
> >think I got everything running properly because the DataBindingExample
> >works correctly, but I encourage you to test more examples to be sure that
> >I didn't miss anything.
> >
> >If you're using the Ant build, you need to be sure to wipe before building
> >each of the repositories after you pull the latest changes. Be sure to
> >pull
> >from all three repos! This will ensure that the new dependencies are
> >downloaded to replace the old ones, and everything will be in sync.
> >
> >flex-falcon:
> >ant wipe-all
> >
> >flex-typedefs:
> >ant wipe
> >
> >flex-asjs:
> >ant super-clean
> >
> >I ran all of these on the Ant CI server, and I'll make tweaks as needed if
> >anything appears to break.
> >
> >- Josh
>
>
Re: [FlexJS] Updated Closure compiler from v20151015 to v20161201
Posted by Alex Harui <ah...@adobe.com>.
Thanks Josh! I had to make one fix for Maven in flex-typedefs, but your
changes build with Ant and Maven locally for me.
-Alex
On 12/16/16, 3:42 PM, "Josh Tynjala" <jo...@gmail.com> wrote:
>Hey folks,
>
>I updated flex-falcon to use a newer build of Closure compiler,
>specifically v20161201. This also required an update of the Guava
>dependency from v17.0 to v20.0. I have made the required changes to the
>dependencies for both Ant and Maven builds.
>
>An update to Closure compiler means that we have the latest features and
>bug fixes from Google for optimizing our JS release builds. For instance,
>one new feature that prompted my desire to update should allow us to
>improve JS source maps for release builds (to step through the original
>ActionScript instead of the generated js-debug JavaScript). It also means
>updated externs with the newest JavaScript browser APIs becoming exposed
>to
>ActionScript. Finally, the v20151015 build is getting to be over a year
>old
>now, and the longer we wait to update, the harder it will become!
>
>This change also affected the flex-typedefs and flex-asjs repositories a
>bit. I had to make a few tweaks here and there because Closure compiler or
>the externs became a little more strict, and some APIs were renamed. I
>think I got everything running properly because the DataBindingExample
>works correctly, but I encourage you to test more examples to be sure that
>I didn't miss anything.
>
>If you're using the Ant build, you need to be sure to wipe before building
>each of the repositories after you pull the latest changes. Be sure to
>pull
>from all three repos! This will ensure that the new dependencies are
>downloaded to replace the old ones, and everything will be in sync.
>
>flex-falcon:
>ant wipe-all
>
>flex-typedefs:
>ant wipe
>
>flex-asjs:
>ant super-clean
>
>I ran all of these on the Ant CI server, and I'll make tweaks as needed if
>anything appears to break.
>
>- Josh