[GitHub] [airflow] kaxil commented on a change in pull request #12085: Remove explicit casting to List when sorted() is applied

[GitBox <gi...@apache.org>]

kaxil commented on a change in pull request #12085:
URL: https://github.com/apache/airflow/pull/12085#discussion_r517277080



##########
File path: tests/build_provider_packages_dependencies.py
##########
@@ -242,7 +242,7 @@ def insert_documentation(deps_dict: Dict[str, List[str]], res: List[str]):
         print(f"Total: {len(errors)} errors.")
     unique_sorted_dependencies: Dict[str, List[str]] = {}
     for key in sorted(dependencies.keys()):
-        unique_sorted_dependencies[key] = sorted(list(set(dependencies[key])))
+        unique_sorted_dependencies[key] = sorted(set(dependencies[key]))

Review comment:
       This might fail MyPy coz of L243: `unique_sorted_dependencies: Dict[str, List[str]] = {}`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org