[GitHub] [iceberg] szehon-ho commented on a diff in pull request #5227: backport #5204 to Spark3.2

[GitBox <gi...@apache.org>]

szehon-ho commented on code in PR #5227:
URL: https://github.com/apache/iceberg/pull/5227#discussion_r917177221


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/source/SparkScanBuilder.java:
##########
@@ -100,7 +100,13 @@ public Filter[] pushFilters(Filter[] filters) {
     List<Filter> pushed = Lists.newArrayListWithExpectedSize(filters.length);
 
     for (Filter filter : filters) {
-      Expression expr = SparkFilters.convert(filter);
+      Expression expr = null;
+      try {
+        expr = SparkFilters.convert(filter);
+      } catch (IllegalArgumentException e) {
+        // converting to Iceberg Expression failed, so this expression cannot be pushed down

Review Comment:
   Yea there was a similar comment on : https://github.com/apache/iceberg/pull/5204#discussion_r914817448, but seemed the positive filters.  I'm ok to log unsuccessful filters too (could also add the exprs not successfully bound as well in the next statement)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org