[GitHub] [pulsar] geraudster opened a new pull request #4322: [pulsar-io-elastic-search] Change default document type

[GitBox <gi...@apache.org>]

geraudster opened a new pull request #4322: [pulsar-io-elastic-search] Change default document type
URL: https://github.com/apache/pulsar/pull/4322
 
 
   ### Motivation
   
   When running Elasticsearch sink on ES 7.0.1, message indexation fails with the following error :
   
   ```
   - Encountered exception in sink write: 
   org.elasticsearch.ElasticsearchStatusException: Elasticsearch exception [type=illegal_argument_exception, reason=Rejecting mapping update to [geoloc-pulsar] as the final mapping would have more than 1 type: [_doc, doc]]
   ```
   
   According to https://www.elastic.co/guide/en/elasticsearch/reference/6.3/removal-of-types.html#_schedule_for_removal_of_mapping_types, the recommended document type to use is `_doc`.
   
   ### Modifications
   
   Replace document type `doc` with recommended value `_doc`.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ### Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: no
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: no
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services