You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "lingsamuel (via GitHub)" <gi...@apache.org> on 2023/05/25 07:29:29 UTC
[GitHub] [apisix-helm-chart] lingsamuel opened a new pull request, #547: chore: re-struct values
lingsamuel opened a new pull request, #547:
URL: https://github.com/apache/apisix-helm-chart/pull/547
To make the helm chart values clearer and easier to understand, and to be consistent with the APISIX configuration, this PR has the following changes.
- The following K8s-related keys are moved from `apisix` to root:
- `apisix.kind`, `apisix.replicaCount`, `apisix.priorityClassName`, `apisix.podAnnotations`
- `apisix.podSecurityContext`, `apisix.securityContext`, `apisix.podDisruptionBudget`, `apisix.resources`
- `apisix.hostNetwork`, `apisix.nodeSelector`, `apisix.tolerations`, `apisix.affinity`, `apisix.timezone`, `apisix.extraEnvVars`, `apisix.image`
- For example, `apisix.kind` has been moved to `kind`
- The following APISIX-related keys are moved from root to `apisix`:
- `deployment`, `admin`, `dns`, `discovery`, `vault`
- `plugins`, `stream_plugins`, `pluginAttrs`, `extPlugin`, `customPlugins`
- For example, `deployment` has been moved to `apisix.deployment`
- Other APISIX related changes:
- Remove `apisix.enabled` option. It's useless because users can use the apisix-ingress-controller helm chart directly.
- Move `wasmPlugins` to `apisix.wasm`
- Move `apisix.httpRouter` to `apisix.router.http`
- Move `apisix.enableCustomizedConfig` to `apisix.fullCustomConfig.enabled`
- Move `apisix.customizedConfig` to `apisix.fullCustomConfig.config`
- Nginx-related keys changes:
- Move `nginx` to `apisix.nginx`
- Move `logs` to `apisix.nginx.logs`
- Move `configurationSnippet` to `apisix.nginx.configurationSnippet`
- Move `apisix.customLuaSharedDicts` to `apisix.nginx.customLuaSharedDicts`
- Gateway, service, ingress, tls/ssl related changes:
- Move `gateway.tls` to `apisix.ssl` except `gateway.tls.servicePort`
- Move `gateway.ingress` to `ingress`
- Move `gateway` to `service`
- Metrics changes:
- The following keys are moved from `serviceMonitor` to `apisix.prometheus`
- `serviceMonitor.path`, `serviceMonitor.metricsPrefix`, `serviceMonitor.containerPort`
- Move `serviceMonitor` to `metrics.serviceMonitor`
- Rename `metrics.serviceMonitor.enabled` to `metrics.serviceMonitor.create`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #547: chore: re-struct apisix chart values
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 merged PR #547:
URL: https://github.com/apache/apisix-helm-chart/pull/547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #547: chore: re-struct apisix chart values
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on PR #547:
URL: https://github.com/apache/apisix-helm-chart/pull/547#issuecomment-1575922440
I have switched the base branch to dev, so we can maintain v0.x, v1.x and this v2.x on different branches. Later on, we can set dev as the default branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #547: [draft] chore: re-struct values
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on code in PR #547:
URL: https://github.com/apache/apisix-helm-chart/pull/547#discussion_r1205349064
##########
charts/apisix/Chart.yaml:
##########
@@ -31,7 +31,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 1.4.0
+version: 1.5.0
Review Comment:
Since it will be a major breaking change. I recommend using v2.x for maintenance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org