[jira] [Commented] (GEODE-4122) Parameterized tests are skipped when not run with correct runner factory

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299195#comment-16299195 ] 

ASF GitHub Bot commented on GEODE-4122:
---------------------------------------

PurelyApplied opened a new pull request #1197: GEODE-4122: Add runner annotation to avoid skipping tests with Parameterized
URL: https://github.com/apache/geode/pull/1197
 
 
   * Optimize imports in touched files.
   * Fix small error in GcCommandDUnitTest in error phrasing
   * The following will be corrected in separate tickets:
   * - QueryCommandTest
   * - ShutdownCommandDUnitTest
   * - CacheServerSSLConnectionDUnitTest
   
   ---
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Parameterized tests are skipped when not run with correct runner factory
> ------------------------------------------------------------------------
>
>                 Key: GEODE-4122
>                 URL: https://issues.apache.org/jira/browse/GEODE-4122
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>              Labels: testing
>
> Initial bug in GEODE-1350, tests annotated with {{@RunWith(Parameterized.class)}} are not correctly detected during testing.  This is corrected when the test class also contains the annotation {{@Parameterized.UseParametersRunnerFactory(CategoryWithParameterizedRunnerFactory.class)}}.
> The following is an possibly-incomplete list of tests containing the offending {{@RunWith}} annotation but not the correcting {{@Parameterized.UseParametersRunnerFactory}} annotation, matching on the regex {{@RunWith\(Parameterized\.class\)\n(?!@Parameterized)}}
> {noformat}
> BaseStringConverterJUnitTest.java
> CacheServerSSLConnectionDUnitTest.java
> ChangeLogLevelCommandDUnitTest.java
> ClusterConfigurationDUnitTest.java
> GatewayReceiverFactoryImplJUnitTest.java
> GcCommandDUnitTest.java
> IndexSecurityDUnitTest.java
> PartitionedIndexSecurityDUnitTest.java
> PdxPartitionedQuerySecurityAllowedQueriesDUnitTest.java
> PdxQuerySecurityAllowedQueriesDUnitTest.java
> PdxQuerySecurityRestrictedQueriesDUnitTest.java
> PRCacheListenerInvocationTest.java
> PRCacheListenerWithInterestPolicyAllInvocationTest.java
> PulseConnectivityTest.java
> QueryCommandTest.java
> ShowLogCommandDUnitTest.java
> ShutdownCommandDUnitTest.java
> {noformat}
> Closure of this ticket should also include a UnitTest or extension to the {{test.gradle}} that ensures no future test includes the one annotation without the other.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)