You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/01/15 06:25:51 UTC
Review Request 42341: Redirected requests to leading master for
/scheduler endpoint.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42341/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-3832
https://issues.apache.org/jira/browse/MESOS-3832
Repository: mesos
Description
-------
This is a followup patch addressing comments on r41052. It would be good to fix this before 0.27 goes out.
The current patch redirects to the current master, if a leader has been elected. If a leader has not been elected yet, it returns `ServiceUnavailable` as before.
Diffs
-----
src/master/http.cpp bcafc7aff89659a68352f3876ce6042f8b34bd5d
Diff: https://reviews.apache.org/r/42341/diff/
Testing
-------
make check + curl. Due to MESOS-2976, spawning multiple masters is not possible.
Thanks,
Anand Mazumdar
Re: Review Request 42341: Redirected requests to leading master for
/scheduler endpoint.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42341/#review114752
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 15, 2016, 5:25 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42341/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 5:25 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3832
> https://issues.apache.org/jira/browse/MESOS-3832
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a followup patch addressing comments on r41052. It would be good to fix this before 0.27 goes out.
>
> The current patch redirects to the current master, if a leader has been elected. If a leader has not been elected yet, it returns `ServiceUnavailable` as before.
>
>
> Diffs
> -----
>
> src/master/http.cpp bcafc7aff89659a68352f3876ce6042f8b34bd5d
>
> Diff: https://reviews.apache.org/r/42341/diff/
>
>
> Testing
> -------
>
> make check + curl. Due to MESOS-2976, spawning multiple masters is not possible.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 42341: Redirected requests to leading master for
/scheduler endpoint.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42341/#review114686
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42341]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 15, 2016, 5:25 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42341/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 5:25 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-3832
> https://issues.apache.org/jira/browse/MESOS-3832
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This is a followup patch addressing comments on r41052. It would be good to fix this before 0.27 goes out.
>
> The current patch redirects to the current master, if a leader has been elected. If a leader has not been elected yet, it returns `ServiceUnavailable` as before.
>
>
> Diffs
> -----
>
> src/master/http.cpp bcafc7aff89659a68352f3876ce6042f8b34bd5d
>
> Diff: https://reviews.apache.org/r/42341/diff/
>
>
> Testing
> -------
>
> make check + curl. Due to MESOS-2976, spawning multiple masters is not possible.
>
>
> Thanks,
>
> Anand Mazumdar
>
>