[GitHub] [solr] janhoy commented on pull request #1935: SOLR-15960 Unified use of system properties and environment variables

["janhoy (via GitHub)" <gi...@apache.org>]

janhoy commented on PR #1935:
URL: https://github.com/apache/solr/pull/1935#issuecomment-1722898115

   Tests pass, @epugh can you have a first quick review and tell if this helps your CLI work? After your first feedback I can invite more reviewers.
   
   I feel the principle is well proven by the fact that I removed explicit parsing of `SOLR_MODULES` variable in `bin/solr`, and still `test_modules.bats` pass tests both for `-Dsolr.modules` and `export SOLR_MODULES`.
   
   I want to keep the scope of this PR somewhat limited. Can follow up with new PRs that remove cruft from the scripts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org