You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/06/06 17:30:18 UTC
[jira] [Commented] (BEAM-2364) PCollectionView should not be a
PValue, it should expand to its underlying PCollection
[ https://issues.apache.org/jira/browse/BEAM-2364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039301#comment-16039301 ]
ASF GitHub Bot commented on BEAM-2364:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/3303
[BEAM-2364] Expand all PValues to component PCollections always
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
Update the implementation of WriteView
The PCollectionView is constructed within the composite override, but
WriteView just produces a primitive PCollection which has no consumers.
Track the ViewWriter within the Direct Runner, and utilize that
transform rather than the producer to update PCollection Watermarks.
Remove most Flink View overrides. All of the overrides are materially
identical within the flink runner, so use a single override to replace
all of them.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam direct_write_view_as_primitive_again
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3303.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3303
----
commit 812f83e676a7d67e06829784c396911935b233ff
Author: Thomas Groh <tg...@google.com>
Date: 2017-06-02T01:39:58Z
Expand all PValues to component PCollections always
Update the implementation of WriteView
The PCollectionView is constructed within the composite override, but
WriteView just produces a primitive PCollection which has no consumers.
Track the ViewWriter within the Direct Runner, and utilize that
transform rather than the producer to update PCollection Watermarks.
Remove most Flink View overrides. All of the overrides are materially
identical within the flink runner, so use a single override to replace
all of them.
----
> PCollectionView should not be a PValue, it should expand to its underlying PCollection
> --------------------------------------------------------------------------------------
>
> Key: BEAM-2364
> URL: https://issues.apache.org/jira/browse/BEAM-2364
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Thomas Groh
> Labels: backward-incompatible
>
> This bug has been present for a very long time.
> It is a change to {{@Internal}} details but is going to be backwards-incompatible in a couple ways there, because backwards compatible behavior is incorrect. But we need to be very careful with the surrounding logic.
> The particular motivating need is that as long as a PCollectionView expands to only itself, the outputs for surgery and serialization are not correct. There may be a solution involving hardcoded logic, TBD.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)