You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2023/12/24 17:23:41 UTC
[PR] WIP: Implement serde for CSV and Parquet FileSinkExec [arrow-datafusion]
andygrove opened a new pull request, #8646:
URL: https://github.com/apache/arrow-datafusion/pull/8646
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/8645
Depends on https://github.com/apache/arrow-datafusion/pull/8641
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Needed by Ballista
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Implement serde for CSV and Parquet FileSinkExec, based on existing support for JSON FileSinkExec.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Yes, new tests added.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement serde for CSV and Parquet FileSinkExec [arrow-datafusion]
Posted by "devinjdangelo (via GitHub)" <gi...@apache.org>.
devinjdangelo commented on PR #8646:
URL: https://github.com/apache/arrow-datafusion/pull/8646#issuecomment-1872392088
This LGTM @andygrove! I am planning to attempt a more significant refactor in #8667 as discussed with @alamb and might be able to simplify adding support for some of the more advanced file writing options, including externally defined file types is the goal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement serde for CSV and Parquet FileSinkExec [arrow-datafusion]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #8646:
URL: https://github.com/apache/arrow-datafusion/pull/8646
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement serde for CSV and Parquet FileSinkExec [arrow-datafusion]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on code in PR #8646:
URL: https://github.com/apache/arrow-datafusion/pull/8646#discussion_r1438367139
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -1220,20 +1222,22 @@ message ParquetWriterOptions {
}
message CsvWriterOptions {
Review Comment:
We have not released a version of DataFusion that contains `CsvWriterOptions` yet, so it is safe to change the field numbers here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement serde for CSV and Parquet FileSinkExec [arrow-datafusion]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #8646:
URL: https://github.com/apache/arrow-datafusion/pull/8646#issuecomment-1872265448
@devinjdangelo fyi, this is now ready for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Implement serde for CSV and Parquet FileSinkExec [arrow-datafusion]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove commented on PR #8646:
URL: https://github.com/apache/arrow-datafusion/pull/8646#issuecomment-1872394823
Thanks for the reviews @avantgardnerio and @devinjdangelo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org