[jira] [Updated] (HIVE-4126) remove support for lead/lag UDFs outside of UDAF args

["Phabricator (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Phabricator updated HIVE-4126:
------------------------------

    Attachment: HIVE-4126.D9105.1.patch

hbutani requested code review of "HIVE-4126 [jira] remove support for lead/lag UDFs outside of UDAF args".

Reviewers: JIRA, ashutoshc

remove support for lead/lag UDFs outside of UDAF args

Select Expressions such as
p_size - lead(p_size,1)
are currently handled as non aggregation expressions done after all over clauses are evaluated.
Once we allow different partitions in a single select list(Jira 4041), these become ambiguous.

	the equivalent way to do such things is either to use lead/lag UDAFs with expressions ( support added with Jira 4081)
	stack windowing clauses with inline queries. select lead(r,1).. from (select rank() as r....)...

TEST PLAN
  existing tests

REVISION DETAIL
  https://reviews.facebook.net/D9105

AFFECTED FILES
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
  ql/src/test/queries/clientpositive/leadlag.q
  ql/src/test/queries/clientpositive/leadlag_queries.q
  ql/src/test/queries/clientpositive/ptf.q
  ql/src/test/queries/clientpositive/windowing.q
  ql/src/test/results/clientpositive/leadlag_queries.q.out
  ql/src/test/results/clientpositive/ptf.q.out
  ql/src/test/results/clientpositive/windowing.q.out

MANAGE HERALD RULES
  https://reviews.facebook.net/herald/view/differential/

WHY DID I GET THIS EMAIL?
  https://reviews.facebook.net/herald/transcript/22065/

To: JIRA, ashutoshc, hbutani

                
> remove support for lead/lag UDFs outside of UDAF args
> -----------------------------------------------------
>
>                 Key: HIVE-4126
>                 URL: https://issues.apache.org/jira/browse/HIVE-4126
>             Project: Hive
>          Issue Type: Bug
>          Components: PTF-Windowing
>            Reporter: Harish Butani
>            Assignee: Harish Butani
>         Attachments: HIVE-4126.D9105.1.patch
>
>
> Select Expressions such as 
> p_size - lead(p_size,1)
> are currently handled as non aggregation expressions done after all over clauses are evaluated.
> Once we allow different partitions in a single select list(Jira 4041), these become ambiguous. 
> - the equivalent way to do such things is either to use lead/lag UDAFs with expressions ( support added with Jira 4081)
> - stack windowing clauses with inline queries. select lead(r,1).. from (select rank() as r....)...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira