You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/02/16 23:58:32 UTC

[kudu-CR] [kudu-jepsen] run kudu CLI tool under 'kudu' user

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9356


Change subject: [kudu-jepsen] run kudu CLI tool under 'kudu' user
......................................................................

[kudu-jepsen] run kudu CLI tool under 'kudu' user

Since cd41990 was committed, the 'kudu cluster ksck' CLI tool command
started returning failure exit code if running not under the service
superuser account (i.e. not under 'kudu' user) because fetching Raft
consensus information on a tablet requires service superuser-level
privileges.

To fix that, at least the two alternatives are available:
  * Run the CLI tool under the service superuser account ('kudu' user).
  * Run the 'kudu cluster ksck' sub-command with the
    --consensus=false option, so it would not try to fetch consensus
    information on existing tablets.

The former alternative makes more sense because the list of privileges
required to call server methods is evolving.  Also, in future we may
need to do other queries using the kudu CLI tool in the context of
Jepsen tests for Kudu.

Change-Id: I7e556e901308871d0bbe6091be41a7a365421222
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
1 file changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/9356/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e556e901308871d0bbe6091be41a7a365421222
Gerrit-Change-Number: 9356
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [kudu-jepsen] run kudu CLI tool under 'kudu' user

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9356 )

Change subject: [kudu-jepsen] run kudu CLI tool under 'kudu' user
......................................................................

[kudu-jepsen] run kudu CLI tool under 'kudu' user

Since cd41990 was committed, the 'kudu cluster ksck' CLI tool command
started returning failure exit code if running not under the service
superuser account (i.e. not under 'kudu' user) because fetching Raft
consensus information on a tablet requires service superuser-level
privileges.

To fix that, at least the two alternatives are available:
  * Run the CLI tool under the service superuser account ('kudu' user).
  * Run the 'kudu cluster ksck' sub-command with the
    --consensus=false option, so it would not try to fetch consensus
    information on existing tablets.

The former alternative makes more sense because the list of privileges
required to call server methods is evolving.  Also, in future we may
need to do other queries using the kudu CLI tool in the context of
Jepsen tests for Kudu.

Change-Id: I7e556e901308871d0bbe6091be41a7a365421222
Reviewed-on: http://gerrit.cloudera.org:8080/9356
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M java/kudu-jepsen/src/main/clojure/jepsen/kudu/util.clj
1 file changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Hao Hao: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e556e901308871d0bbe6091be41a7a365421222
Gerrit-Change-Number: 9356
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] [kudu-jepsen] run kudu CLI tool under 'kudu' user

Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/9356 )

Change subject: [kudu-jepsen] run kudu CLI tool under 'kudu' user
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e556e901308871d0bbe6091be41a7a365421222
Gerrit-Change-Number: 9356
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sat, 17 Feb 2018 00:37:42 +0000
Gerrit-HasComments: No