You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/01 17:36:33 UTC

[GitHub] [kafka] cmccabe commented on a change in pull request #10013: MINOR: Remove ZK dependency for __transaction_state partition count

cmccabe commented on a change in pull request #10013:
URL: https://github.com/apache/kafka/pull/10013#discussion_r568011675



##########
File path: core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala
##########
@@ -30,6 +30,13 @@ import org.apache.kafka.common.record.RecordBatch
 import org.apache.kafka.common.requests.TransactionResult
 import org.apache.kafka.common.utils.{LogContext, ProducerIdAndEpoch, Time}
 
+class TransactionStateTopicPartitionCountViaZooKeeper(zkClient: KafkaZkClient,

Review comment:
       I left a comment in the other PR.  We do not want to get rid of startup, or have a callback function.  See #10008.  I agree with @ijuma that we should consolidate these into one PR to keep the discussion in one place.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org