[GitHub] [bookkeeper] merlimat commented on a diff in pull request #3872: Add log for entry log file delete.

["merlimat (via GitHub)" <gi...@apache.org>]

merlimat commented on code in PR #3872:
URL: https://github.com/apache/bookkeeper/pull/3872#discussion_r1139452933


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java:
##########
@@ -745,6 +745,7 @@ protected void extractMetaFromEntryLogs() throws EntryLogMetadataMapException {
                 EntryLogMetadata entryLogMeta = entryLogger.getEntryLogMetadata(entryLogId, throttler);
                 removeIfLedgerNotExists(entryLogMeta);
                 if (entryLogMeta.isEmpty()) {
+                    LOG.info("Entry log file {} is empty, delete it from disk.", entryLogId);

Review Comment:
   `entryLogId` is not directly the same (eg: it gets converted to hex)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org