[GitHub] [flink] twalthr commented on a change in pull request #8822: [FLINK-12899][table] Introduce a resolved expression with data type

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #8822: [FLINK-12899][table] Introduce a resolved expression with data type
URL: https://github.com/apache/flink/pull/8822#discussion_r296197028
 
 

 ##########
 File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/stream/table/ColumnFunctionsTest.scala
 ##########
 @@ -323,40 +323,6 @@ class ColumnFunctionsTest extends TableTestBase {
 
     verifyAll(tab1, tab2, expected)
   }
-
-  @Test
-  def testRenameColumns(): Unit = {
-    val t = util.addTable[(Double, Long, String)]('a, 'b, 'c)
-
-    val tab1 = t.renameColumns(withColumns('a) as 'd).select("d, b")
-    val tab2 = t.renameColumns("withColumns(a) as d").select('d, 'b)
-
-    val expected =
-      unaryNode(
-        "DataStreamCalc",
-        streamTableNode(t),
-        term("select", "a AS d", "b")
-      )
-
-    verifyAll(tab1, tab2, expected)
-  }
-
-  @Test
-  def testDropColumns(): Unit = {
 
 Review comment:
   Very good point. It was more of an accident.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services