You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/18 16:18:11 UTC

[GitHub] [spark] MaxGekk commented on a diff in pull request #38177: [WIP][SPARK-40663][SQL](Final) Migrate execution errors onto error classes

MaxGekk commented on code in PR #38177:
URL: https://github.com/apache/spark/pull/38177#discussion_r998448644


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4245,5 +4245,40 @@
     "message" : [
       "Not enough memory to build and broadcast the table to all worker nodes. As a workaround, you can either disable broadcast by setting <autoBroadcastjoinThreshold> to -1 or increase the spark driver memory by setting <driverMemory> to a higher value<analyzeTblMsg>"
     ]
+  },
+  "_LEGACY_ERROR_TEMP_2276" : {
+    "message" : [
+      "Hive table <tableName> with ANSI intervals is not supported"
+    ]
+  },
+  "_LEGACY_ERROR_TEMP_2277" : {
+    "message" : [
+      "Number of dynamic partitions created is <numWrittenParts>\", which is more than <maxDynamicPartitions>\". To solve this try to set <maxDynamicPartitionsKey> to at least <numWrittenParts>."

Review Comment:
   Could you remove \" around `\", which is more than <maxDynamicPartitions>\"`



##########
core/src/main/resources/error/error-classes.json:
##########
@@ -4245,5 +4245,40 @@
     "message" : [
       "Not enough memory to build and broadcast the table to all worker nodes. As a workaround, you can either disable broadcast by setting <autoBroadcastjoinThreshold> to -1 or increase the spark driver memory by setting <driverMemory> to a higher value<analyzeTblMsg>"
     ]
+  },
+  "_LEGACY_ERROR_TEMP_2276" : {
+    "message" : [
+      "Hive table <tableName> with ANSI intervals is not supported"
+    ]
+  },
+  "_LEGACY_ERROR_TEMP_2277" : {
+    "message" : [
+      "Number of dynamic partitions created is <numWrittenParts>\", which is more than <maxDynamicPartitions>\". To solve this try to set <maxDynamicPartitionsKey> to at least <numWrittenParts>."
+    ]
+  },
+  "_LEGACY_ERROR_TEMP_2278" : {
+    "message" : [
+      "The input $valueType '<input>' does not match the given number format: '<format>'"

Review Comment:
   `$valueType` -> `<valueType>`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org