[jira] [Commented] (HBASE-20981) Rollback stateCount accounting thrown-off when exception out of rollbackState

["Sakthi (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-20981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17022549#comment-17022549 ] 

Sakthi commented on HBASE-20981:
--------------------------------

This commit is missing from 2.2 & 2.3. Let me create a subtask for it.

> Rollback stateCount accounting thrown-off when exception out of rollbackState
> -----------------------------------------------------------------------------
>
>                 Key: HBASE-20981
>                 URL: https://issues.apache.org/jira/browse/HBASE-20981
>             Project: HBase
>          Issue Type: Bug
>          Components: amv2
>    Affects Versions: 2.0.1
>            Reporter: Michael Stack
>            Assignee: Jack Bearden
>            Priority: Major
>             Fix For: 3.0.0, 2.1.1, 2.0.2
>
>         Attachments: HBASE-20981.002.patch, HBASE-20981.branch-2.001.patch
>
>
> Found by might [~allan163] over in HBASE-20893. Quoting Allan:
> {code}
> But, there is truly a bug here,
>   @Override
>   protected void rollback(final TEnvironment env)
>       throws IOException, InterruptedException {
>     if (isEofState()) stateCount--;
>     try {
>       updateTimestamp();
>       rollbackState(env, getCurrentState());
>       stateCount--;
>     } finally {
>       updateTimestamp();
>     }
>   }
> We need to decrease the stateCount when rolling back, so we can rollback for the previous state correctly. But. since a exception is thrown, the decrease for stateCount never happen. So ProcedureExecutor will continue to rollback for only one state(the one throw a exception) until the end of the execution stack.
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)