[GitHub] [superset] kgabryje commented on a change in pull request #16700: fix(explore): make clicked dnd filters unique

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #16700:
URL: https://github.com/apache/superset/pull/16700#discussion_r708200682



##########
File path: superset-frontend/src/explore/components/DatasourcePanel/types.ts
##########
@@ -31,3 +31,7 @@ export function isDatasourcePanelDndItem(
 ): item is DatasourcePanelDndItem {
   return item?.value && item?.type;
 }
+
+export function isDndItemValue(item: any): item is DndItemValue {
+  return item?.value && item?.type;

Review comment:
       Is that correct? `DndItemValue` is `ColumnMeta | Metric`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org