[jira] [Resolved] (ORCHESTRA-68) RequestParameterProviderManager.encodeAndAttachParameters might throw NullPointerException

["Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>]

     [ https://issues.apache.org/jira/browse/ORCHESTRA-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved ORCHESTRA-68.
-------------------------------------
       Resolution: Fixed
         Assignee: Leonardo Uribe
    Fix Version/s: 1.6

I agree the fix has sense. Thanks to Leo Büttiker for provide this patch.

> RequestParameterProviderManager.encodeAndAttachParameters might throw NullPointerException 
> -------------------------------------------------------------------------------------------
>
>                 Key: ORCHESTRA-68
>                 URL: https://issues.apache.org/jira/browse/ORCHESTRA-68
>             Project: MyFaces Orchestra
>          Issue Type: Bug
>          Components: RequestParameterProvider
>    Affects Versions: 1.5
>            Reporter: Leo Büttiker
>            Assignee: Leonardo Uribe
>             Fix For: 1.6
>
>
> Under certain circumstances which I unfortunately can not reproduce all the time (during a heavy load selenium test with ajax) the method RequestParameterProviderManager.encodeAndAttachParameters throws an expection because a provider in the list providers is null. 
> The assumption is that due to multi-threading the array list might get corrupt under certain conditions. When I replace the list with a synchronized list the error does not occur. Fixing the bug can therefor achieved by replacing getProviders with:
> {code}
>     protected List getProviders() {
>         if (providers == null) {
>             providers = Collections.synchronizedList(new ArrayList());
>         }
>         return providers;
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)