You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by mp...@apache.org on 2017/11/21 09:09:13 UTC
[1/2] mesos git commit: MesosTidy [misc-use-after-move]: Added NOLINT.
Repository: mesos
Updated Branches:
refs/heads/master 7d5ee197e -> 447ae6356
MesosTidy [misc-use-after-move]: Added NOLINT.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/b0af0703
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/b0af0703
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/b0af0703
Branch: refs/heads/master
Commit: b0af07039093877f7301a8291b3190ff8949a016
Parents: 7d5ee19
Author: Michael Park <mp...@apache.org>
Authored: Mon Nov 20 23:55:59 2017 -0800
Committer: Michael Park <mp...@apache.org>
Committed: Mon Nov 20 23:55:59 2017 -0800
----------------------------------------------------------------------
3rdparty/libprocess/include/process/future.hpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/b0af0703/3rdparty/libprocess/include/process/future.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/include/process/future.hpp b/3rdparty/libprocess/include/process/future.hpp
index 97bc0c8..d48dfd7 100644
--- a/3rdparty/libprocess/include/process/future.hpp
+++ b/3rdparty/libprocess/include/process/future.hpp
@@ -1417,7 +1417,7 @@ const Future<T>& Future<T>::onDiscarded(DiscardedCallback&& callback) const
// TODO(*): Invoke callback in another execution context.
if (run) {
- callback();
+ callback(); // NOLINT(misc-use-after-move)
}
return *this;
[2/2] mesos git commit: Fixed MesosTidy warning
[google-readability-redundant-smartptr-get].
Posted by mp...@apache.org.
Fixed MesosTidy warning [google-readability-redundant-smartptr-get].
```
src/slave/containerizer/mesos/provisioner/provisioner.cpp:734:27:
warning: redundant get() call on smart pointer
[google-readability-redundant-smartptr-get]
futures.push_back(store.get()->prune(images, activeLayerPaths));
^~~~~~~~~~~~~
store
```
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/447ae635
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/447ae635
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/447ae635
Branch: refs/heads/master
Commit: 447ae63567022a97cd271cc0a77f8f7e01a2d78d
Parents: b0af070
Author: Michael Park <mp...@apache.org>
Authored: Tue Nov 21 00:20:52 2017 -0800
Committer: Michael Park <mp...@apache.org>
Committed: Tue Nov 21 00:21:40 2017 -0800
----------------------------------------------------------------------
src/slave/containerizer/mesos/provisioner/provisioner.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/447ae635/src/slave/containerizer/mesos/provisioner/provisioner.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/mesos/provisioner/provisioner.cpp b/src/slave/containerizer/mesos/provisioner/provisioner.cpp
index d19dc1a..9d1a4e5 100644
--- a/src/slave/containerizer/mesos/provisioner/provisioner.cpp
+++ b/src/slave/containerizer/mesos/provisioner/provisioner.cpp
@@ -731,7 +731,7 @@ Future<Nothing> ProvisionerProcess::pruneImages(
}
}
- futures.push_back(store.get()->prune(images, activeLayerPaths));
+ futures.push_back(store->prune(images, activeLayerPaths));
}
return collect(futures)