You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Mohit Kataria (JIRA)" <ji...@apache.org> on 2019/05/16 04:58:00 UTC
[jira] [Comment Edited] (OAK-8309) SLOW_QUERY_COUNT don't get
updated for each slow query.
[ https://issues.apache.org/jira/browse/OAK-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16840979#comment-16840979 ]
Mohit Kataria edited comment on OAK-8309 at 5/16/19 4:57 AM:
-------------------------------------------------------------
In Oak-8148, i had used slowCount[1] to update slowquery stats. But sometimes the read count ([2]) count goes ahead of slowCount (because of hidden nodes). As a result exception gets thrown before slowCount breaches traversal threshold.
[1]: [https://github.com/apache/jackrabbit-oak/blob/f39431c09f3f23f7652ce753b77ca08ed31ce375/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java#L505]
[2]: [https://github.com/apache/jackrabbit-oak/blob/1b380d3fb6dcb18702649f0c0a997a71315abbd4/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/Cursors.java#L348]
was (Author: tihom88):
In Oak-8148, i had used slowCount[1] to update slowquery stats. But sometimes the read count ([2]) count goes ahead of slowCount (because of hidden nodes). As a result exception gets thrown before slowCount breaches traversal threshold.
[1]: [https://github.com/apache/jackrabbit-oak/blob/f39431c09f3f23f7652ce753b77ca08ed31ce375/oak-co[1]re/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java#L505|https://github.com/apache/jackrabbit-oak/blob/f39431c09f3f23f7652ce753b77ca08ed31ce375/oak-core/src/main/java/org/apache/jackrabbit/oak/query/ast/SelectorImpl.java#L505] ]
[2]: [https://github.com/apache/jackrabbit-oak/blob/1b380d3fb6dcb18702649f0c0a997a71315abbd4/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/Cursors.java#L348]
> SLOW_QUERY_COUNT don't get updated for each slow query.
> --------------------------------------------------------
>
> Key: OAK-8309
> URL: https://issues.apache.org/jira/browse/OAK-8309
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: indexing
> Affects Versions: 1.12.0
> Reporter: Mohit Kataria
> Priority: Major
>
> The metrics added should show slow query count but the count is not getting updated for each query.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)