You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "m1a2st (via GitHub)" <gi...@apache.org> on 2024/12/09 13:00:51 UTC
[PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
m1a2st opened a new pull request, #18104:
URL: https://github.com/apache/kafka/pull/18104
Jira: https://issues.apache.org/jira/browse/KAFKA-18186
To enhance the developer experience, when the user runs `./gradlew idea`, IntelliJ IDEA should automatically configure the Java settings.
I test in my local
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: set `options.release` to make Intellij configure suitable language level automatically [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #18104:
URL: https://github.com/apache/kafka/pull/18104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2533766685
Hello @ableegoldman,
We should not set java version in the Project Structure > Project Settings > Modules, when we import the new kafka project, and refresh the gradle build, You can test below in different modules
> 1. setting this to 11 does not seem to have any effect (eg I can still use Optional#isPresent in the IDE)
> 2. refreshing gradle wipes out the language level override and sets it back to "Project Default"
In Project Structure > Project Settings > Modules it also is project default, but I file a issue to intellij community to trace it.
[issue](https://youtrack.jetbrains.com/issue/IDEA-364556/Gradle-setting-java-modules-version-not-inconsistency-in-the-intellij-Project-Settings-modules)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2537356744
@chia7712 My bad 😅 Why was I thinking Optional#isPresent was newer than that? Anyways thanks for the sanity check
@m1a2st Tested with a better API and can now verify that this is working as intended. Thanks for the fix!
<img width="692" alt="image" src="https://github.com/user-attachments/assets/4a0bd02d-2468-4705-8714-80a5e73938f2" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2532787552
https://youtrack.jetbrains.com/issue/IDEA-241948/IntelliJ-doesnt-pick-up-the-correct-module-language-level-from-composite-gradle-builds seems related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2536146259
> setting this to 11 does not seem to have any effect (eg I can still use Optional#isPresent in the IDE)
Apologies, but `Optional#isPresent` was introduced in JDK 8 ([Java 8 Documentation](https://docs.oracle.com/javase/8/docs/api/java/util/Optional.html#isPresent--)), so it should be available in all modules for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2532733752
Adding `sourceCompatibility` doesn't change things either for. I also tried deleting `compiler.xml` (where these settings are seemingly set) and invalidating the IntelliJ cache.
Version details:
IntelliJ IDEA 2024.3.1 (Community Edition)
Runtime version: 21.0.5+8-b631.28 aarch64 (JCEF 122.1.9)
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2533247888
Good point @chia7712 - it seems like the internal model for IntelliJ is actually correct even though the settings screen isn't. One other inconsistency I noticed is that IntelliJ seems to only have a single Java standard library association, so whichever SDK is picked at the project level will be the one one used when someone follows a definition (even if the actual version used by some modules may be older).
So, to summarize:
1. This seems good enough for now, both IntelliJ editor tooltips and compiler output seem to be correct.
2. We should probably state in the README that configuring the IntelliJ SDK to Java 17 is likely to be the best compromise given that most modules have Java 17 as the minimum version (this matters for code navigation). In fact, it makes sense to cover the expected IntelliJ experience in the README too as it's a bit unintuitive.
3. We should probably file an issue with IntelliJ to address the settings inconsistency.
2 and 3 are unrelated to this PR, but I think good to do if people have cycles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "Yunyung (via GitHub)" <gi...@apache.org>.
Yunyung commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2531160856
It works on my local "IntelliJ IDEA 2024.3 (Community Edition)".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2532714670
This doesn't seem to work for me. I see "Language Level: 21" for all my modules while using this branch. None of the screenshots above seem to show it working either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2533343930
Thanks for @ijuma suggestion
> We should probably state in the README that configuring the IntelliJ SDK to Java 17 is likely to be the best compromise given that most modules have Java 17 as the minimum version (this matters for code navigation). In fact, it makes sense to cover the expected IntelliJ experience in the README too as it's a bit unintuitive.
I file a Jira to trace it [KAFKA-18203](https://issues.apache.org/jira/browse/KAFKA-18203)
> We should probably file an issue with IntelliJ to address the settings inconsistency.
I will also file an issue to intellij community
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #18104:
URL: https://github.com/apache/kafka/pull/18104#discussion_r1877030678
##########
build.gradle:
##########
@@ -125,6 +125,7 @@ ext {
options.compilerArgs << "-encoding" << "UTF-8"
options.compilerArgs += ["--release", String.valueOf(releaseVersion)]
Review Comment:
typo: `options.release = releaseVersion` -> we should use this instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: set `options.release` to make Intellij configure suitable language level automatically [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2542823094
This change breaks the "version" used by joint compilation, resulting in the Java code in the core module being compiled into incorrect byte-code. I have opened [KAFKA-18242](https://issues.apache.org/jira/browse/KAFKA-18242) to address this issue. As a simple solution, we need to add `options.compilerArgs += ["--release", String.valueOf(releaseVersion)]` back to the Scala compiler due to [Gradle issue #13762](https://github.com/gradle/gradle/issues/13762).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #18104:
URL: https://github.com/apache/kafka/pull/18104#discussion_r1876946798
##########
build.gradle:
##########
@@ -125,6 +125,7 @@ ext {
options.compilerArgs << "-encoding" << "UTF-8"
options.compilerArgs += ["--release", String.valueOf(releaseVersion)]
Review Comment:
Could you please try to use `options.compilerArgs += ["--release", String.valueOf(releaseVersion)]` instead of `options.compilerArgs += ["--release", String.valueOf(releaseVersion)]`. The former can set the `sourceCompatibility` automatically (see https://github.com/gradle/gradle/blob/784ffbe7b04e3dd31f4e05e12906efc7a410757f/platforms/jvm/plugins-java-base/src/main/java/org/gradle/api/plugins/JavaBasePlugin.java#L331)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2533596088
I'm trying to test this out by setting the language level for the streams module under 'Project Structure', but:
1. setting this to 11 does not seem to have any effect (eg I can still use `Optional#isPresent` in the IDE)
2. refreshing gradle wipes out the language level override and sets it back to "Project Default"
Am I doing something wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2532819467
As far as I can tell, the language level ends up the same as the Java version Gradle is configured to run with:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2533167360
@ijuma Thank you for your report. Could you please try using JDK 17 features in the clients module, as [here](https://github.com/apache/kafka/pull/18104#issuecomment-2530611762)? I encountered the same issue as you and will investigate it later. However, the main improvement is that IntelliJ IDEA can recognize the supported features for different modules, even though the project structure doesn't seem to work correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "m1a2st (via GitHub)" <gi...@apache.org>.
m1a2st commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2530611762
I test in my local machine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18186: add sourceCompatibility back to build.gradle to allow idea to configure suitable language level automatically [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #18104:
URL: https://github.com/apache/kafka/pull/18104#issuecomment-2532304171
@agavra @ableegoldman Could you please take a look, as you provided feedback on #17522? With this patch, IntelliJ IDEA can automatically recognize the language level for each module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org