You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by ly...@apache.org on 2024/07/30 10:30:39 UTC
(incubator-devlake) branch dev-1 updated (7ac45c78d -> 3fea1255b)
This is an automated email from the ASF dual-hosted git repository.
lynwee pushed a change to branch dev-1
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
from 7ac45c78d fix: circleci plugin pagination (#7770)
add 2bf7f73ac fix 6892 - avoid adding clause when table not present (#6943)
new 3fea1255b fix(domainlayer): simplify codes
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
backend/core/models/domainlayer/ticket/issue.go | 7 -------
backend/plugins/gitlab/tasks/trigger_job_collector.go | 8 ++++++--
2 files changed, 6 insertions(+), 9 deletions(-)
(incubator-devlake) 01/01: fix(domainlayer): simplify codes
Posted by ly...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
lynwee pushed a commit to branch dev-1
in repository https://gitbox.apache.org/repos/asf/incubator-devlake.git
commit 3fea1255bc7069b8be3c12dd1cb845bae20019bd
Author: d4x1 <15...@qq.com>
AuthorDate: Tue Jul 30 18:30:31 2024 +0800
fix(domainlayer): simplify codes
---
backend/core/models/domainlayer/ticket/issue.go | 7 -------
1 file changed, 7 deletions(-)
diff --git a/backend/core/models/domainlayer/ticket/issue.go b/backend/core/models/domainlayer/ticket/issue.go
index 816571a4a..25039e8df 100644
--- a/backend/core/models/domainlayer/ticket/issue.go
+++ b/backend/core/models/domainlayer/ticket/issue.go
@@ -18,7 +18,6 @@ limitations under the License.
package ticket
import (
- "errors"
"github.com/apache/incubator-devlake/core/models/domainlayer"
"time"
)
@@ -111,9 +110,6 @@ func (issue Issue) IsIncident() bool {
}
func (issue Issue) ToIncidentAssignee() (*IncidentAssignee, error) {
- if !issue.IsIncident() {
- return nil, errors.New("issue type is not INCIDENT, cannot generate incident_assignee")
- }
return &IncidentAssignee{
IncidentId: issue.Id,
AssigneeId: issue.AssigneeId,
@@ -123,9 +119,6 @@ func (issue Issue) ToIncidentAssignee() (*IncidentAssignee, error) {
}
func (issue Issue) ToIncident() (*Incident, error) {
- if !issue.IsIncident() {
- return nil, errors.New("issue type is not INCIDENT, cannot generate incident")
- }
incident := &Incident{
DomainEntity: issue.DomainEntity,
Url: issue.Url,