You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/11/30 23:48:02 UTC
[kudu-CR] Make threadpool-test less flaky
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5293
to review the following change.
Change subject: Make threadpool-test less flaky
......................................................................
Make threadpool-test less flaky
Under heavy load, threadpool-test may take more than 10 seconds in rare
cases and cause a test failure. This simply increases the timeout.
Change-Id: I6465922e5b43dc9aff80fa2b6e6549061bfd0425
---
M src/kudu/util/threadpool-test.cc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/5293/1
--
To view, visit http://gerrit.cloudera.org:8080/5293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6465922e5b43dc9aff80fa2b6e6549061bfd0425
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Make threadpool-test less flaky
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Make threadpool-test less flaky
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5293/1/src/kudu/util/threadpool-test.cc
File src/kudu/util/threadpool-test.cc:
Line 179: alarm(0);
Since you're fixing up this test, could you put this in a ScopedCleanup? That way, even if an ASSERT fires, we'll still remove the alarm.
--
To view, visit http://gerrit.cloudera.org:8080/5293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6465922e5b43dc9aff80fa2b6e6549061bfd0425
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Make threadpool-test less flaky
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Make threadpool-test less flaky
......................................................................
Patch Set 1:
Looped 1000x in RELEASE mode: http://dist-test.cloudera.org/job?job_id=mpercy.1480548969.28650
--
To view, visit http://gerrit.cloudera.org:8080/5293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6465922e5b43dc9aff80fa2b6e6549061bfd0425
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Make threadpool-test less flaky
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: Make threadpool-test less flaky
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5293/1/src/kudu/util/threadpool-test.cc
File src/kudu/util/threadpool-test.cc:
Line 179: alarm(0);
> Since you're fixing up this test, could you put this in a ScopedCleanup? Th
Done
--
To view, visit http://gerrit.cloudera.org:8080/5293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6465922e5b43dc9aff80fa2b6e6549061bfd0425
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Make threadpool-test less flaky
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has uploaded a new patch set (#2).
Change subject: Make threadpool-test less flaky
......................................................................
Make threadpool-test less flaky
Under heavy load, threadpool-test may take more than 10 seconds in rare
cases and cause a test failure. This change increases the timeout.
Also reliably disable the alarm, even if an assertion fires, using a
ScopedCleanup object.
Change-Id: I6465922e5b43dc9aff80fa2b6e6549061bfd0425
---
M src/kudu/util/threadpool-test.cc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/93/5293/2
--
To view, visit http://gerrit.cloudera.org:8080/5293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6465922e5b43dc9aff80fa2b6e6549061bfd0425
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Make threadpool-test less flaky
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: Make threadpool-test less flaky
......................................................................
Make threadpool-test less flaky
Under heavy load, threadpool-test may take more than 10 seconds in rare
cases and cause a test failure. This change increases the timeout.
Also reliably disable the alarm, even if an assertion fires, using a
ScopedCleanup object.
Change-Id: I6465922e5b43dc9aff80fa2b6e6549061bfd0425
Reviewed-on: http://gerrit.cloudera.org:8080/5293
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/util/threadpool-test.cc
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6465922e5b43dc9aff80fa2b6e6549061bfd0425
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Make threadpool-test less flaky
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Make threadpool-test less flaky
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6465922e5b43dc9aff80fa2b6e6549061bfd0425
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Make threadpool-test less flaky
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Make threadpool-test less flaky
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6465922e5b43dc9aff80fa2b6e6549061bfd0425
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No