You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2025/09/10 03:56:40 UTC

[PR] [#2591] fix(client): Incorrect header length for getLocalShuffleDataV3 [uniffle]

zuston opened a new pull request, #2604:
URL: https://github.com/apache/uniffle/pull/2604

   ### What changes were proposed in this pull request?
   
   Fix incorrect header length for getLocalShuffleDataV3
   
   ### Why are the changes needed?
   
   This will make getLocalShuffleDataV3 invalid
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Tested in our internal jobs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#2591] fix(client): Incorrect header length for getLocalShuffleDataV3 [uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #2604:
URL: https://github.com/apache/uniffle/pull/2604#issuecomment-3273543948

   Could you add a UT for this fix?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#2591] fix(client): Incorrect header length for getLocalShuffleDataV3 [uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #2604:
URL: https://github.com/apache/uniffle/pull/2604


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#2591] fix(client): Incorrect header length for getLocalShuffleDataV3 [uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #2604:
URL: https://github.com/apache/uniffle/pull/2604#issuecomment-3273312971

   ## Test Results
    3 120 files  ±0   3 120 suites  ±0   6h 49m 51s ⏱️ - 1m 10s
    1 201 tests ±0   1 200 ✅ ±0   1 💤 ±0  0 ❌ ±0 
   15 211 runs  ±0  15 196 ✅ ±0  15 💤 ±0  0 ❌ ±0 
   
   Results for commit 467eb6c8. ± Comparison against base commit 96bf76cb.
   
   [test-results]:data:application/gzip;base64,H4sIAOgDwWgC/03MSQ7DIAyF4atErLuIHaCkl6kIg4SaoWJYRb17SUoJy/fZ+ndi3WwCeXQDYH/rSEgutlsnL6Pb1ixI2QiZ8j0eH/mhzmdISv2sv+zl3odVsNLNGa4P4/3mi/i0nlWGAGXWKoORVytV9oemeu42qrZlcTEPQvndTFyJQSBqycWATBouewQ6otCgBVI7TZJ8vl4ifZQUAQAA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#2591] fix(client): Incorrect header length for getLocalShuffleDataV3 [uniffle]

Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #2604:
URL: https://github.com/apache/uniffle/pull/2604#issuecomment-3278658225

   > Could you add a UT for this fix?
   
   This is the followup PR for #2603 . Due to the missing server side implementation, it's hard to add end-to-end tests. But I think I will implement this in the server side if having free time. Do you have passion on this next PR? @cchung100m 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org

Re: [PR] [#2591] fix(client): Incorrect header length for getLocalShuffleDataV3 [uniffle]

Posted by "cchung100m (via GitHub)" <gi...@apache.org>.
cchung100m commented on PR #2604:
URL: https://github.com/apache/uniffle/pull/2604#issuecomment-3290309509

   Hi @zuston 
   
   Thanks for the suggestion and I can try to add test cases for it later. 😸 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org