You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "michaeljmarshall (via GitHub)" <gi...@apache.org> on 2023/05/16 17:33:09 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request, #20336: [cleanup] Consolidate certs used in tests
michaeljmarshall opened a new pull request, #20336:
URL: https://github.com/apache/pulsar/pull/20336
Builds on: https://github.com/apache/pulsar/pull/20289
### Motivation
There are many certificates in our test code base. It would be much simpler to have one place were we create and manage certificates so that when we need to make changes, they are consolidated.
There is likely one or two more PRs to finish consolidating certs.
### Modifications
* Remove certs that are no longer used
* Replace references to old certs with references to the `certificate-authority` certs
* Create new server certs with valid hostnames on them so that tests will pass. Document the process used to create these certs.
* Fix an issue in the `PulsarTestContext` where the configuration was not correctly updated.
* Remove configurations that allow for insecure connections in tests that are doing some kind of TLS verification. The only places where we leave insecure validation in place is tests that are specifically verifying the functionallity.
### Verifying this change
When tests pass, this change will be correctly verified.
### Documentation
- [x] `doc`
This PR includes doc changes
### Matching PR in forked repository
PR in forked repository: https://github.com/michaeljmarshall/pulsar/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #20336: [cleanup] Consolidate certs used in tests
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #20336:
URL: https://github.com/apache/pulsar/pull/20336#issuecomment-1550365966
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20336: [cleanup] Consolidate certs used in tests
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20336:
URL: https://github.com/apache/pulsar/pull/20336#issuecomment-1550748313
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20336?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20336](https://app.codecov.io/gh/apache/pulsar/pull/20336?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (05342e9) into [master](https://app.codecov.io/gh/apache/pulsar/commit/426ad3e53ba621c442bce89eb208add8f9d1563e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (426ad3e) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20336 +/- ##
============================================
+ Coverage 72.93% 72.95% +0.01%
+ Complexity 31973 31972 -1
============================================
Files 1868 1868
Lines 138663 138663
Branches 15248 15248
============================================
+ Hits 101133 101156 +23
+ Misses 29484 29457 -27
- Partials 8046 8050 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.08% <ø> (-0.04%)` | :arrow_down: |
| systests | `24.93% <ø> (+0.06%)` | :arrow_up: |
| unittests | `72.22% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ache/pulsar/broker/loadbalance/LinuxInfoUtils.java](https://app.codecov.io/gh/apache/pulsar/pull/20336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9MaW51eEluZm9VdGlscy5qYXZh) | `43.65% <ø> (ø)` | |
| [...ker/loadbalance/impl/LinuxBrokerHostUsageImpl.java](https://app.codecov.io/gh/apache/pulsar/pull/20336?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9pbXBsL0xpbnV4QnJva2VySG9zdFVzYWdlSW1wbC5qYXZh) | `79.68% <ø> (-4.69%)` | :arrow_down: |
... and [71 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20336/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall merged pull request #20336: [cleanup] Consolidate certs used in tests
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall merged PR #20336:
URL: https://github.com/apache/pulsar/pull/20336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org