You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/28 09:23:36 UTC
[GitHub] [airflow] yuqian90 commented on issue #7331: [AIRFLOW-6657]
Deprecate BaseBranchOperator
yuqian90 commented on issue #7331: [AIRFLOW-6657] Deprecate BaseBranchOperator
URL: https://github.com/apache/airflow/pull/7331#issuecomment-592425840
> Did we make any decisions on if we need this or not? I remember there was a chat somewhere after you opened this PR.
Hi @ashb I did post the PR in #development but I don't think people replied back then. But you are right we should discuss if `BaseBranchOperator` should be deprecated.
I read the discussion history on https://github.com/apache/airflow/pull/5231. My understanding is @chronitis originally added `BaseBranchOperator` when most of the skipping logic lived inside `BranchPythonOperator` itself. He then went on to refactor `BranchPythonOperator` and `SkipMixin`. He did a good job refactoring them till a point where almost all of the logic now lives in `SkipMixin.skip_all_except()` itself, making it much more reusable. So it rendered `BaseBranchOperator` much less useful (because people can use `SkipMixin` directly if they wish).
Also as I pointed out, whatever we can do with `BaseBranchOperator` can also be done with `BranchPythonOperator`. That's why i find it unnecessary to have a separate class.
@chronitis @ashb please let me know what you think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services