You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Cliff Jansen <cl...@gmail.com> on 2013/01/28 20:59:38 UTC
Review Request: part5 changes for g++
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9124/
-----------------------------------------------------------
Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.
Description
-------
Changes for C++ not handled by other flags. Basically:
inttypes.h issues
aggregate assignment
late declaration of auto vars in the middle of a switch statement
explicit casts of void* to xyz*
minor const fussiness
Note that the next step to VC++ on Windows has no additional language syntax issues. It is all about missing C99 headers and library support.
This addresses bug proton-159.
https://issues.apache.org/jira/browse/proton-159
Diffs
-----
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/python/CMakeLists.txt 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/python/python.i 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/examples/messenger/c/CMakeLists.txt 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/engine.h 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/ssl.h 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/message/message.c 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/platform_fmt.h PRE-CREATION
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/sasl/sasl.c 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/scanner.c 1439550
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/types.c 1439550
Diff: https://reviews.apache.org/r/9124/diff/
Testing
-------
This compiles and runs, but only if you stitch the previous 4 related patches together. It does not work standalone.
Thanks,
Cliff Jansen
Re: Review Request: part5 changes for g++
Posted by Kenneth Giusti <kg...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9124/#review15965
-----------------------------------------------------------
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/engine.h
<https://reviews.apache.org/r/9124/#comment34260>
I'm not fond of these implied order initializers - been burned before by structure changes that implicitly change these.
I'd recommend the following more heavyhanded yet safer pattern:
type var = {};
var.field1 = xxx;
var.fieldZ = yyy;
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c
<https://reviews.apache.org/r/9124/#comment34262>
ditto
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c
<https://reviews.apache.org/r/9124/#comment34263>
ditto
http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/types.c
<https://reviews.apache.org/r/9124/#comment34261>
Ditto previous nit.
- Kenneth Giusti
On Jan. 28, 2013, 7:59 p.m., Cliff Jansen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9124/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 7:59 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.
>
>
> Description
> -------
>
> Changes for C++ not handled by other flags. Basically:
>
> inttypes.h issues
> aggregate assignment
> late declaration of auto vars in the middle of a switch statement
> explicit casts of void* to xyz*
> minor const fussiness
>
> Note that the next step to VC++ on Windows has no additional language syntax issues. It is all about missing C99 headers and library support.
>
>
> This addresses bug proton-159.
> https://issues.apache.org/jira/browse/proton-159
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/python/CMakeLists.txt 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/python/python.i 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/examples/messenger/c/CMakeLists.txt 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/engine.h 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/ssl.h 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/message/message.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/platform_fmt.h PRE-CREATION
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/sasl/sasl.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/scanner.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/types.c 1439550
>
> Diff: https://reviews.apache.org/r/9124/diff/
>
>
> Testing
> -------
>
> This compiles and runs, but only if you stitch the previous 4 related patches together. It does not work standalone.
>
>
> Thanks,
>
> Cliff Jansen
>
>
Re: Review Request: part5 changes for g++
Posted by Rafael Schloming <rh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9124/#review16019
-----------------------------------------------------------
Ship it!
Ship It!
- Rafael Schloming
On Jan. 28, 2013, 7:59 p.m., Cliff Jansen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9124/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 7:59 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.
>
>
> Description
> -------
>
> Changes for C++ not handled by other flags. Basically:
>
> inttypes.h issues
> aggregate assignment
> late declaration of auto vars in the middle of a switch statement
> explicit casts of void* to xyz*
> minor const fussiness
>
> Note that the next step to VC++ on Windows has no additional language syntax issues. It is all about missing C99 headers and library support.
>
>
> This addresses bug proton-159.
> https://issues.apache.org/jira/browse/proton-159
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/python/CMakeLists.txt 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/python/python.i 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/examples/messenger/c/CMakeLists.txt 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/engine.h 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/ssl.h 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/message/message.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/platform_fmt.h PRE-CREATION
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/sasl/sasl.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/scanner.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/types.c 1439550
>
> Diff: https://reviews.apache.org/r/9124/diff/
>
>
> Testing
> -------
>
> This compiles and runs, but only if you stitch the previous 4 related patches together. It does not work standalone.
>
>
> Thanks,
>
> Cliff Jansen
>
>
Re: Review Request: part5 changes for g++
Posted by Mary Hinton <m....@nc.rr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9124/#review15936
-----------------------------------------------------------
Ship it!
Ship It!
- Mary Hinton
On Jan. 28, 2013, 7:59 p.m., Cliff Jansen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9124/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 7:59 p.m.)
>
>
> Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and Mary Hinton.
>
>
> Description
> -------
>
> Changes for C++ not handled by other flags. Basically:
>
> inttypes.h issues
> aggregate assignment
> late declaration of auto vars in the middle of a switch statement
> explicit casts of void* to xyz*
> minor const fussiness
>
> Note that the next step to VC++ on Windows has no additional language syntax issues. It is all about missing C99 headers and library support.
>
>
> This addresses bug proton-159.
> https://issues.apache.org/jira/browse/proton-159
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/CMakeLists.txt 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/python/CMakeLists.txt 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/bindings/python/python.i 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/examples/messenger/c/CMakeLists.txt 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/engine.h 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/ssl.h 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/codec/codec.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/engine/engine.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/message/message.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/messenger.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/platform_fmt.h PRE-CREATION
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/proton.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/sasl/sasl.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/scanner.c 1439550
> http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/src/types.c 1439550
>
> Diff: https://reviews.apache.org/r/9124/diff/
>
>
> Testing
> -------
>
> This compiles and runs, but only if you stitch the previous 4 related patches together. It does not work standalone.
>
>
> Thanks,
>
> Cliff Jansen
>
>