You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Mark Thomas <ma...@apache.org> on 2024/02/13 13:11:49 UTC
February release tagging
Hi all,
Just a quick status update.
I was hopping to have tagged 11.0.x by now but I have found a couple of
issues.
1. FFM on MacOS is broken. This might be related to me updating OpenSSL
(via homebrew) from 3.2.0 to 3.2.1
2. I'm seeing a couple of HTTP/2 test failures on Windows.
I'm currently investigating.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: February release tagging
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Rémy,
On 2/13/24 09:34, Rémy Maucherat wrote:
> On Tue, Feb 13, 2024 at 3:28 PM Christopher Schultz
> <ch...@christopherschultz.net> wrote:
>>
>> Mark,
>>
>> On 2/13/24 08:11, Mark Thomas wrote:
>>> Hi all,
>>>
>>> Just a quick status update.
>>>
>>> I was hopping to have tagged 11.0.x by now but I have found a couple of
>>> issues.
>>>
>>> 1. FFM on MacOS is broken. This might be related to me updating OpenSSL
>>> (via homebrew) from 3.2.0 to 3.2.1
>>
>> I still have OpenSSL 3.2.0 on MacOS, both x86-64 and M2 available.
>>
>> How do I specifically test FFM? Just run the unit tests as usual on main
>> HEAD?
>
> On CI, it is using 1.1.1 ;)
> OpenSSLLibrary.init OpenSSL successfully initialized using FFM
> [OpenSSL 1.1.1f 31 Mar 2020]
>
> So you can run whatever OpenSSL but only using the latest Java.
I've just run all the unit tests on main-HEAD on aarch64 MacOS with Java
21 and OpenSSL 3.2.0, and only a singe test failed:
org.apache.tomcaat.util.net.TestSsl.NIO
The error is "SSLHandshakeException: Remote host terminated the
handshake" caused by "EOLException: SSL peer shut down incorrectly".
The failure appears to be in the client, reporting that the server
shut-down the connection incorrectly.
In the same test report, there are some "SKIPPED" items, inclluding
"expected true, got false" for a number of them. Are those ... expected?
Copy/paste isn't convenient from my M2 Mac into this email, but I can
provide the full report if that would be helpful.
There are about 10 unit-tests with skipped tests for both NIO and NIO2.
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: February release tagging
Posted by Rémy Maucherat <re...@apache.org>.
On Tue, Feb 13, 2024 at 3:28 PM Christopher Schultz
<ch...@christopherschultz.net> wrote:
>
> Mark,
>
> On 2/13/24 08:11, Mark Thomas wrote:
> > Hi all,
> >
> > Just a quick status update.
> >
> > I was hopping to have tagged 11.0.x by now but I have found a couple of
> > issues.
> >
> > 1. FFM on MacOS is broken. This might be related to me updating OpenSSL
> > (via homebrew) from 3.2.0 to 3.2.1
>
> I still have OpenSSL 3.2.0 on MacOS, both x86-64 and M2 available.
>
> How do I specifically test FFM? Just run the unit tests as usual on main
> HEAD?
On CI, it is using 1.1.1 ;)
OpenSSLLibrary.init OpenSSL successfully initialized using FFM
[OpenSSL 1.1.1f 31 Mar 2020]
So you can run whatever OpenSSL but only using the latest Java.
Rémy
> -chris
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: February release tagging
Posted by Christopher Schultz <ch...@christopherschultz.net>.
Mark,
On 2/13/24 08:11, Mark Thomas wrote:
> Hi all,
>
> Just a quick status update.
>
> I was hopping to have tagged 11.0.x by now but I have found a couple of
> issues.
>
> 1. FFM on MacOS is broken. This might be related to me updating OpenSSL
> (via homebrew) from 3.2.0 to 3.2.1
I still have OpenSSL 3.2.0 on MacOS, both x86-64 and M2 available.
How do I specifically test FFM? Just run the unit tests as usual on main
HEAD?
-chris
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: February release tagging
Posted by Rémy Maucherat <re...@apache.org>.
On Tue, Feb 13, 2024 at 6:49 PM Mark Thomas <ma...@apache.org> wrote:
>
> On 13/02/2024 16:57, Mark Thomas wrote:
> > On 13/02/2024 14:14, Rémy Maucherat wrote:
>
> <snip/>
>
> >> I tested a fresh build of trunk (3.3 dev) and it seems to work fine
> >> for me on Linux. What is the error ?
> >
> > This isn't OpenSSL or Java EA version related.
> >
> > There error is:
> >
> > "WARNING: <path to java executable> is loading libcrypto in an unsafe way"
> >
> > and then the JVM exits.
> >
> > It is caused by this commit:
> > https://github.com/apache/tomcat/commit/830771823edbb79d2884eb1c6f5122e81df4df78
>
> Need to decide what to do about this:
> - fix it later
> - try and fix it now
> - revert the change and fix it later
>
> > I found this GitHub issue comment
> >
> > https://github.com/cl-plus-ssl/cl-plus-ssl/issues/114#issuecomment-770370592
> >
> > that suggests that what is happening is Tomcat is trying to load
> > "/usr/lib/libcrypto.dylib" which is a stub which is intended to trigger
> > the crash.
The Panama people have found another link which explains the problem even more:
https://github.com/sergot/openssl/issues/81
It's not looking very good, most likely the hack will have to stay ...
Rémy
> >
> >>> 2. I'm seeing a couple of HTTP/2 test failures on Windows.
> >
> > I'm looking at these now.
>
> These are fixed.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: February release tagging
Posted by Rémy Maucherat <re...@apache.org>.
On Tue, Feb 13, 2024 at 8:02 PM Mark Thomas <ma...@apache.org> wrote:
>
> On 13/02/2024 19:00, Rémy Maucherat wrote:
> > On Tue, Feb 13, 2024 at 6:49 PM Mark Thomas <ma...@apache.org> wrote:
> >>
> >> On 13/02/2024 16:57, Mark Thomas wrote:
> >>> On 13/02/2024 14:14, Rémy Maucherat wrote:
> >>
> >> <snip/>
> >>
> >>>> I tested a fresh build of trunk (3.3 dev) and it seems to work fine
> >>>> for me on Linux. What is the error ?
> >>>
> >>> This isn't OpenSSL or Java EA version related.
> >>>
> >>> There error is:
> >>>
> >>> "WARNING: <path to java executable> is loading libcrypto in an unsafe way"
> >>>
> >>> and then the JVM exits.
> >>>
> >>> It is caused by this commit:
> >>> https://github.com/apache/tomcat/commit/830771823edbb79d2884eb1c6f5122e81df4df78
> >>
> >> Need to decide what to do about this:
> >> - fix it later
> >> - try and fix it now
> >> - revert the change and fix it later
> >
> > I need to report it to the FFM team, because from your finding it is
> > now trying to load the wrong thing. OTOH, it did fix the library
> > loading for the CI runs (previously libssl was not found), so it's not
> > all on the regression side.
> >
> > Given that I would prefer ignoring it in this build.
>
> ACK.
Since you haven't tagged yet, I put in a hack ...
Rémy
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: February release tagging
Posted by Mark Thomas <ma...@apache.org>.
On 13/02/2024 19:00, Rémy Maucherat wrote:
> On Tue, Feb 13, 2024 at 6:49 PM Mark Thomas <ma...@apache.org> wrote:
>>
>> On 13/02/2024 16:57, Mark Thomas wrote:
>>> On 13/02/2024 14:14, Rémy Maucherat wrote:
>>
>> <snip/>
>>
>>>> I tested a fresh build of trunk (3.3 dev) and it seems to work fine
>>>> for me on Linux. What is the error ?
>>>
>>> This isn't OpenSSL or Java EA version related.
>>>
>>> There error is:
>>>
>>> "WARNING: <path to java executable> is loading libcrypto in an unsafe way"
>>>
>>> and then the JVM exits.
>>>
>>> It is caused by this commit:
>>> https://github.com/apache/tomcat/commit/830771823edbb79d2884eb1c6f5122e81df4df78
>>
>> Need to decide what to do about this:
>> - fix it later
>> - try and fix it now
>> - revert the change and fix it later
>
> I need to report it to the FFM team, because from your finding it is
> now trying to load the wrong thing. OTOH, it did fix the library
> loading for the CI runs (previously libssl was not found), so it's not
> all on the regression side.
>
> Given that I would prefer ignoring it in this build.
ACK.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: February release tagging
Posted by Rémy Maucherat <re...@apache.org>.
On Tue, Feb 13, 2024 at 6:49 PM Mark Thomas <ma...@apache.org> wrote:
>
> On 13/02/2024 16:57, Mark Thomas wrote:
> > On 13/02/2024 14:14, Rémy Maucherat wrote:
>
> <snip/>
>
> >> I tested a fresh build of trunk (3.3 dev) and it seems to work fine
> >> for me on Linux. What is the error ?
> >
> > This isn't OpenSSL or Java EA version related.
> >
> > There error is:
> >
> > "WARNING: <path to java executable> is loading libcrypto in an unsafe way"
> >
> > and then the JVM exits.
> >
> > It is caused by this commit:
> > https://github.com/apache/tomcat/commit/830771823edbb79d2884eb1c6f5122e81df4df78
>
> Need to decide what to do about this:
> - fix it later
> - try and fix it now
> - revert the change and fix it later
I need to report it to the FFM team, because from your finding it is
now trying to load the wrong thing. OTOH, it did fix the library
loading for the CI runs (previously libssl was not found), so it's not
all on the regression side.
Given that I would prefer ignoring it in this build.
Rémy
> > I found this GitHub issue comment
> >
> > https://github.com/cl-plus-ssl/cl-plus-ssl/issues/114#issuecomment-770370592
> >
> > that suggests that what is happening is Tomcat is trying to load
> > "/usr/lib/libcrypto.dylib" which is a stub which is intended to trigger
> > the crash.
> >
> >>> 2. I'm seeing a couple of HTTP/2 test failures on Windows.
> >
> > I'm looking at these now.
>
> These are fixed.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: February release tagging
Posted by Mark Thomas <ma...@apache.org>.
On 13/02/2024 16:57, Mark Thomas wrote:
> On 13/02/2024 14:14, Rémy Maucherat wrote:
<snip/>
>> I tested a fresh build of trunk (3.3 dev) and it seems to work fine
>> for me on Linux. What is the error ?
>
> This isn't OpenSSL or Java EA version related.
>
> There error is:
>
> "WARNING: <path to java executable> is loading libcrypto in an unsafe way"
>
> and then the JVM exits.
>
> It is caused by this commit:
> https://github.com/apache/tomcat/commit/830771823edbb79d2884eb1c6f5122e81df4df78
Need to decide what to do about this:
- fix it later
- try and fix it now
- revert the change and fix it later
> I found this GitHub issue comment
>
> https://github.com/cl-plus-ssl/cl-plus-ssl/issues/114#issuecomment-770370592
>
> that suggests that what is happening is Tomcat is trying to load
> "/usr/lib/libcrypto.dylib" which is a stub which is intended to trigger
> the crash.
>
>>> 2. I'm seeing a couple of HTTP/2 test failures on Windows.
>
> I'm looking at these now.
These are fixed.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: February release tagging
Posted by Mark Thomas <ma...@apache.org>.
On 13/02/2024 14:14, Rémy Maucherat wrote:
> On Tue, Feb 13, 2024 at 2:12 PM Mark Thomas <ma...@apache.org> wrote:
>>
>> Hi all,
>>
>> Just a quick status update.
>>
>> I was hopping to have tagged 11.0.x by now but I have found a couple of
>> issues.
>>
>> 1. FFM on MacOS is broken. This might be related to me updating OpenSSL
>> (via homebrew) from 3.2.0 to 3.2.1
>
> I tested a fresh build of trunk (3.3 dev) and it seems to work fine
> for me on Linux. What is the error ?
This isn't OpenSSL or Java EA version related.
There error is:
"WARNING: <path to java executable> is loading libcrypto in an unsafe way"
and then the JVM exits.
It is caused by this commit:
https://github.com/apache/tomcat/commit/830771823edbb79d2884eb1c6f5122e81df4df78
I found this GitHub issue comment
https://github.com/cl-plus-ssl/cl-plus-ssl/issues/114#issuecomment-770370592
that suggests that what is happening is Tomcat is trying to load
"/usr/lib/libcrypto.dylib" which is a stub which is intended to trigger
the crash.
>> 2. I'm seeing a couple of HTTP/2 test failures on Windows.
I'm looking at these now.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: February release tagging
Posted by Rémy Maucherat <re...@apache.org>.
On Tue, Feb 13, 2024 at 2:12 PM Mark Thomas <ma...@apache.org> wrote:
>
> Hi all,
>
> Just a quick status update.
>
> I was hopping to have tagged 11.0.x by now but I have found a couple of
> issues.
>
> 1. FFM on MacOS is broken. This might be related to me updating OpenSSL
> (via homebrew) from 3.2.0 to 3.2.1
I tested a fresh build of trunk (3.3 dev) and it seems to work fine
for me on Linux. What is the error ?
> 2. I'm seeing a couple of HTTP/2 test failures on Windows.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: February release tagging
Posted by Rémy Maucherat <re...@apache.org>.
On Tue, Feb 13, 2024 at 2:12 PM Mark Thomas <ma...@apache.org> wrote:
>
> Hi all,
>
> Just a quick status update.
>
> I was hopping to have tagged 11.0.x by now but I have found a couple of
> issues.
>
> 1. FFM on MacOS is broken. This might be related to me updating OpenSSL
> (via homebrew) from 3.2.0 to 3.2.1
TBH everyone is probably still on 3.1, so it does not matter. The
build will be replaced next month, so no need to rush with a fix ...
> 2. I'm seeing a couple of HTTP/2 test failures on Windows.
>
> I'm currently investigating.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org