[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6982: Build: Enable --scan for java-ci

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #6982:
URL: https://github.com/apache/iceberg/pull/6982#discussion_r1122638581


##########
.github/workflows/java-ci.yml:
##########
@@ -87,7 +87,7 @@ jobs:
       with:
         distribution: zulu
         java-version: 8
-    - run: ./gradlew -DallVersions build -x test -x javadoc -x integrationTest
+    - run: ./gradlew -DallVersions build -x test -x javadoc -x integrationTest --scan

Review Comment:
   > doesnt this require to agree to gradle's terms of service
   good point, in that case we probably cannot enable it



##########
.github/workflows/java-ci.yml:
##########
@@ -87,7 +87,7 @@ jobs:
       with:
         distribution: zulu
         java-version: 8
-    - run: ./gradlew -DallVersions build -x test -x javadoc -x integrationTest
+    - run: ./gradlew -DallVersions build -x test -x javadoc -x integrationTest --scan

Review Comment:
   > doesnt this require to agree to gradle's terms of service
   
   good point, in that case we probably cannot enable it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org