You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by "mystic-lama (via GitHub)" <gi...@apache.org> on 2023/08/07 19:36:52 UTC

[GitHub] [orc] mystic-lama opened a new pull request, #1573: ORC-1472: Replace deprecated method in TestMurmur3.java

mystic-lama opened a new pull request, #1573:
URL: https://github.com/apache/orc/pull/1573

   ### What changes were proposed in this pull request?
   
   The PR proposes to update the use to deprecate method in TestMurmur3 to recommended one
   Hashing.murmur3_32(seed) has been deprecated and documentation recommends to use Hashing.murmur3_32_fixed
   
   ### Why are the changes needed?
   Updating Deprecated method to use recommended ones is a good practice, as deprecated methods might have bugs or gets removed from subsequent releases.
   
   
   ### How was this patch tested?
   The Unit tests with changes passes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1573: ORC-1472: Replace deprecated method in TestMurmur3.java

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1573:
URL: https://github.com/apache/orc/pull/1573#issuecomment-1670029776

   Thank you, @mystic-lama and @williamhyun .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] williamhyun closed pull request #1573: ORC-1472: Replace deprecated method in TestMurmur3.java

Posted by "williamhyun (via GitHub)" <gi...@apache.org>.
williamhyun closed pull request #1573: ORC-1472: Replace deprecated method in TestMurmur3.java
URL: https://github.com/apache/orc/pull/1573


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1573: ORC-1472: Replace deprecated method in TestMurmur3.java

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #1573:
URL: https://github.com/apache/orc/pull/1573#issuecomment-1668518399

   cc @williamhyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org