You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/07/22 16:43:47 UTC
[GitHub] [dubbo] hengyoush opened a new issue #8339: EventPublishingServiceDiscovery destroy check duplicated
hengyoush opened a new issue #8339:
URL: https://github.com/apache/dubbo/issues/8339
In the org.apache.dubbo.registry.client.EventPublishingServiceDiscovery.destroy():
```java
public void destroy() {
assertDestroyed(DESTROY_ACTION); // 内部调用了isDestroyed方法,如果已经destroy则抛出异常
if (isDestroyed()) { // 此处再次进行判断,如果已经destroy,则打印日志
if (logger.isWarnEnabled()) {
logger.warn("It's ignored to stop current ServiceDiscovery, because it has been stopped.");
}
return;
}
```
Can this place be optimized? If necessary, I can submit a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM commented on issue #8339: EventPublishingServiceDiscovery destroy check duplicated
Posted by GitBox <gi...@apache.org>.
CrazyHZM commented on issue #8339:
URL: https://github.com/apache/dubbo/issues/8339#issuecomment-887472063
Do it with confidence.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM closed issue #8339: EventPublishingServiceDiscovery destroy check duplicated
Posted by GitBox <gi...@apache.org>.
CrazyHZM closed issue #8339:
URL: https://github.com/apache/dubbo/issues/8339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM commented on issue #8339: EventPublishingServiceDiscovery destroy check duplicated
Posted by GitBox <gi...@apache.org>.
CrazyHZM commented on issue #8339:
URL: https://github.com/apache/dubbo/issues/8339#issuecomment-925521057
@hengyoush
Are you still paying attention to this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] CrazyHZM closed issue #8339: EventPublishingServiceDiscovery destroy check duplicated
Posted by GitBox <gi...@apache.org>.
CrazyHZM closed issue #8339:
URL: https://github.com/apache/dubbo/issues/8339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org