You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/11 08:23:48 UTC

[GitHub] [spark] zhengruifeng commented on pull request #28710: [SPARK-31893][ML] Add a generic ClassificationSummary trait

zhengruifeng commented on pull request #28710:
URL: https://github.com/apache/spark/pull/28710#issuecomment-642492980


   `MulticlassMetrics` needs "prediction, label, weight(optional), probability (optional, only for logLoss)", `probability` can be ignored for now;
   
   `BinaryClassificationMetrics` needs "score, label, weight", here score is the `probability` of class 1 in `BinaryLogisticRegressionSummary`;
   
   So I guess we can add a `BinaryClassificationSummary` to support LinearSVC, then `scoreCol` seems no longer needed, several break changes maybe avoided.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org