You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by lu...@apache.org on 2015/09/17 01:21:11 UTC
svn commit: r1703470 - /subversion/trunk/INSTALL
Author: luke1410
Date: Wed Sep 16 23:21:11 2015
New Revision: 1703470
URL: http://svn.apache.org/r1703470
Log:
Remove obsolete (since at least 1.7) step to run gen-make before building
Apache httpd for Windows.
* INSTALL
documentation updated
Modified:
subversion/trunk/INSTALL
Modified: subversion/trunk/INSTALL
URL: http://svn.apache.org/viewvc/subversion/trunk/INSTALL?rev=1703470&r1=1703469&r2=1703470&view=diff
==============================================================================
--- subversion/trunk/INSTALL (original)
+++ subversion/trunk/INSTALL Wed Sep 16 23:21:11 2015
@@ -961,14 +961,6 @@ II. INSTALLATION
This step is only required for building the server dso modules.
- The Subversion gen-make.py script must be run before building Apache or
- Apache and Subversion will be running incompatible versions of apr.
-
- C:>cd src-%DIR%
- C:>python gen-make.py -t dsp --with-httpd=..\httpd-2.0.58
- --with-berkeley-db=db4-win32 --with-openssl=..\openssl-0.9.7f
- --with-zlib=..\zlib --with-libintl=..\svn-win32-libintl
- C:>cd ..
C:>set APACHEDIR=C:\Program Files\Apache Group\Apache2
C:>msdev httpd-2.0.58\apache.dsw /MAKE "BuildBin - Win32 Release"
Re: svn commit: r1703470 - /subversion/trunk/INSTALL
Posted by Stefan <lu...@posteo.de>.
On 17/09/2015 13:14, Branko Čibej wrote:
> On 17.09.2015 01:21, luke1410@apache.org wrote:
>> Author: luke1410
>> Date: Wed Sep 16 23:21:11 2015
>> New Revision: 1703470
>>
>> URL: http://svn.apache.org/r1703470
>> Log:
>> Remove obsolete (since at least 1.7) step to run gen-make before building
>> Apache httpd for Windows.
>>
>> * INSTALL
>> documentation updated
>
> Stefan, please read the log message guidelines at
>
> http://subversion.apache.org/docs/community-guide/conventions.html#log-messages
>
> again. Your last 8 commits all contain that incorrectly formatted part
> that refers to the INSTALL file. This is a minor nit, but we're all so
> used to the formatting that the slight typo sort of pops out.
>
> -- Brane
Thanks for reviewing the commits and the log messages. I've just updated
them to better fit with the standard.
I wasn't too sure about the "Following on xxxx" styles, since I couldn't
find a fully matching example but rather followed the style of existing
logs on trunk.
Please let me know if theres further things which should be changed and
if the style for the "Following up" logs is correct, I'd offer to add
such an example to the community-guide, if that's wanted.
Regards,
Stefan
Re: svn commit: r1703470 - /subversion/trunk/INSTALL
Posted by Branko Čibej <br...@apache.org>.
On 17.09.2015 01:21, luke1410@apache.org wrote:
> Author: luke1410
> Date: Wed Sep 16 23:21:11 2015
> New Revision: 1703470
>
> URL: http://svn.apache.org/r1703470
> Log:
> Remove obsolete (since at least 1.7) step to run gen-make before building
> Apache httpd for Windows.
>
> * INSTALL
> documentation updated
Stefan, please read the log message guidelines at
http://subversion.apache.org/docs/community-guide/conventions.html#log-messages
again. Your last 8 commits all contain that incorrectly formatted part
that refers to the INSTALL file. This is a minor nit, but we're all so
used to the formatting that the slight typo sort of pops out.
-- Brane