[jira] [Commented] (FLUME-1511) Scribe-source doesn't handle zero message request correctly.

["Mike Percy (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLUME-1511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13602948#comment-13602948 ] 

Mike Percy commented on FLUME-1511:
-----------------------------------

+1 lgtm. (I wish we had unit tests for this component)
                
> Scribe-source doesn't handle zero message request correctly.
> ------------------------------------------------------------
>
>                 Key: FLUME-1511
>                 URL: https://issues.apache.org/jira/browse/FLUME-1511
>             Project: Flume
>          Issue Type: Bug
>          Components: Sinks+Sources
>    Affects Versions: v1.2.0, v1.3.0
>            Reporter: Xin Yu
>            Assignee: Denny Ye
>            Priority: Minor
>              Labels: scribe, thrift
>         Attachments: FLUME-1511.patch
>
>
> ScribeSource deosn't handle the zero message request correctly.
> When scribed sends zero message request like this:
>  sent <0> messages to remote scribe server <dwen:1564>
> The log receiver of scribe-source will return ResultCode.TRY_LATER.
> The return value reultes that scribed falls into infinite loop to
> retry to send the zero message request out, and the whole
> message channel is blocked.
> So I suggest that ResultCode.OK is returned when the size of
> LogEntry list is 0.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira