You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/16 04:12:00 UTC
[jira] [Commented] (WEEX-121) draw text crash multi-thread
[ https://issues.apache.org/jira/browse/WEEX-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254720#comment-16254720 ]
ASF GitHub Bot commented on WEEX-121:
-------------------------------------
GitHub user acton393 opened a pull request:
https://github.com/apache/incubator-weex/pull/871
[WEEX-121][iOS] bug-fix draw text crash
there are case when text update frequently, so when main thread drawing text, here updates come,
so the text value must protect here from be setting in multithread, here use lock temporarily.
Bug:121
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/acton393/incubator-weex iOS-text-draw-crash-multithread
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/871.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #871
----
commit 76dd76d06e0813b192a4c82ca17617601fe4760c
Author: acton393 <zh...@gmail.com>
Date: 2017-11-16T04:09:59Z
[WEEX-121][iOS] bug-fix draw text crash
there are case when text update frequently, so when main thread drawing text, here updates come,
so the text value must protect here from be setting in multithread, here use lock temporarily.
Bug:121
----
> draw text crash multi-thread
> -----------------------------
>
> Key: WEEX-121
> URL: https://issues.apache.org/jira/browse/WEEX-121
> Project: Weex
> Issue Type: Bug
> Components: iOS
> Reporter: xingZhang
> Assignee: xingZhang
>
> {code:java}
> Thread 0 Crashed:
> 0 libobjc.A.dylib 0x000000018eea80a0 _objc_retain :16 (in libobjc.A.dylib)
> 1 Taobao4iPhone 0x0000000102d90c14 -[WXTextComponent buildCTAttributeString] WXTextComponent.m:411 (in Taobao4iPhone)
> 2 Taobao4iPhone 0x0000000102d90724 -[WXTextComponent ctAttributedString] WXTextComponent.m:369 (in Taobao4iPhone)
> 3 Taobao4iPhone 0x0000000102d91f18 -[WXTextComponent drawTextWithContext:bounds:padding:view:] WXTextComponent.m:653 (in Taobao4iPhone)
> 4 Taobao4iPhone 0x0000000102d90284 -[WXTextComponent drawRect:] WXTextComponent.m:312 (in Taobao4iPhone)
> 5 Taobao4iPhone 0x0000000102dc9d08 _37-[WXComponent(Display) _displayBlock]_block_invoke WXComponent+Display.m:107 (in Taobao4iPhone)
> 6 Taobao4iPhone 0x0000000102dca164 -[WXComponent(Display) _willDisplayLayer:] WXComponent+Display.m:197 (in Taobao4iPhone)
> 7 Taobao4iPhone 0x0000000102de9fd0 -[WXLayer display] WXLayer.m:29 (in Taobao4iPhone)
> 8 QuartzCore 0x00000001937ae314 CA::Layer::display_if_needed(CA::Transaction*) :228 (in QuartzCore)
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)