You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/12/10 02:37:37 UTC
[GitHub] [nifi] s9514171 opened a new pull request #4720: NIFI-1440 Allow Remote Process Group Target URI to change after creation
s9514171 opened a new pull request #4720:
URL: https://github.com/apache/nifi/pull/4720
This PR allows RPG to modify the target nifi instance URIs again after RPG is created.
the original step, when the RPG start transmit, it will compare the protocol only. if protocol changed, it will discard the state from disk
If user change the URIs to another instance, RPG not only keep the old instance but also add new instance to the state. the RPG will have two different instance at same time and show the errors when transmission.
in order to check if user change the URIs, I stored addition information into persistence files, this is used to check if the current target instance is match with state persistence file in disk.
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4720: NIFI-1440 Allow Remote Process Group Target URI to change after creation
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4720:
URL: https://github.com/apache/nifi/pull/4720#issuecomment-754125862
Hi @s9514171 . Thanks for the Pull Request! Looking at this, though, I'm having a bit of trouble understanding what the changes are that you're proposing. NIFI-1440 is about updating the UI and the backend to allow for changing the the target URI. So if a hostname or an IP address changes, for instance, it can be updated. This was actually added quite a long time ago. So I think NIFI-1440 is probably a duplicate of another Jira.
Are you seeing a problem with changing the Target URI? I did just attempt it, and as far as I can see, all is working fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] s9514171 closed pull request #4720: NIFI-1440 Allow Remote Process Group Target URI to change after creation
Posted by GitBox <gi...@apache.org>.
s9514171 closed pull request #4720:
URL: https://github.com/apache/nifi/pull/4720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] s9514171 commented on pull request #4720: NIFI-1440 Allow Remote Process Group Target URI to change after creation
Posted by GitBox <gi...@apache.org>.
s9514171 commented on pull request #4720:
URL: https://github.com/apache/nifi/pull/4720#issuecomment-754493844
HI @markap14
I faced some issues after I change the URI of the RPG in version 1.12.x
when I changed the target to another instance, the old peers don't be removed, it just append the new peers into local state in disk
RPG will using the both old and new peers to transfer data, and show the errors
due to I saw this issue on JIRA, I misunderstood it was a feature that has never been supported.
I just used version 1.11.4 to test and found that the URI can be changed successfully
Maybe as you said, this Jira is a duplicate and has already been resolved in another Jira
I will open a new Jira and describe in detail the situation I encountered
Please help to review it after I created
Many thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] s9514171 commented on pull request #4720: NIFI-1440 Allow Remote Process Group Target URI to change after creation
Posted by GitBox <gi...@apache.org>.
s9514171 commented on pull request #4720:
URL: https://github.com/apache/nifi/pull/4720#issuecomment-755962979
Hi @markap14
I have created another JIRA and PR https://github.com/apache/nifi/pull/4745 for the bug I encountered
Please help to review
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org