[GitHub] [airflow] uranusjr commented on a diff in pull request #28849: Don't schedule downstream or emit end_of_log on task deferral

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #28849:
URL: https://github.com/apache/airflow/pull/28849#discussion_r1104031925


##########
airflow/cli/commands/task_command.py:
##########
@@ -407,18 +408,19 @@ def task_run(args, dag=None):
     # this should be last thing before running, to reduce likelihood of an open session
     # which can cause trouble if running process in a fork.
     settings.reconfigure_orm(disable_connection_pool=True)
-
+    ret = None
     try:
         if args.interactive:
-            _run_task_by_selected_method(args, dag, ti)
+            ret = _run_task_by_selected_method(args, dag, ti)

Review Comment:
   I this this can just be
   
   ```python
   return _run_task_by_selected_method(args, dag, ti)
   ```
   
   Since the `finally` block is run before the return actually returns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org