You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/02/07 15:20:22 UTC
[GitHub] [ignite] ArtsiomPanko opened a new pull request #7385: Disable
h2.objectcache variable and add unit test
ArtsiomPanko opened a new pull request #7385: Disable h2.objectcache variable and add unit test
URL: https://github.com/apache/ignite/pull/7385
Disable h2.objectcache variable value and add unit test for checking that this variable's value is disable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] pavlukhin commented on a change in pull request #7385:
IGNITE-12610: Disable h2.objectcache variable and add unit test
Posted by GitBox <gi...@apache.org>.
pavlukhin commented on a change in pull request #7385: IGNITE-12610: Disable h2.objectcache variable and add unit test
URL: https://github.com/apache/ignite/pull/7385#discussion_r385600337
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteH2PropertiesTest.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.h2.engine.SysProperties;
+import org.junit.Test;
+import org.junit.Before;
+
+/**
+ * Test to check the values of SysProperties variables are correct
+ */
+public class IgniteH2PropertiesTest extends GridCommonAbstractTest {
+ /** Instance name. */
+ private static final String INSTANCE_NAME = "test_node";
+
+ /** */
+ @Before
+ public void setUp() throws Exception {
+ try {
+ startGrid(INSTANCE_NAME, "examples/config/example-ignite.xml");
Review comment:
Will the simplest `startGrid()` fit here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] pavlukhin commented on a change in pull request #7385:
IGNITE-12610: Disable h2.objectcache variable and add unit test
Posted by GitBox <gi...@apache.org>.
pavlukhin commented on a change in pull request #7385: IGNITE-12610: Disable h2.objectcache variable and add unit test
URL: https://github.com/apache/ignite/pull/7385#discussion_r385602431
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteH2PropertiesTest.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.h2.engine.SysProperties;
+import org.junit.Test;
+import org.junit.Before;
+
+/**
+ * Test to check the values of SysProperties variables are correct
+ */
+public class IgniteH2PropertiesTest extends GridCommonAbstractTest {
+ /** Instance name. */
+ private static final String INSTANCE_NAME = "test_node";
+
+ /** */
+ @Before
+ public void setUp() throws Exception {
+ try {
+ startGrid(INSTANCE_NAME, "examples/config/example-ignite.xml");
+ } finally {
+ stopAllGrids();
+ }
+ }
+
+ /**
+ * @throws Exception If failed.
Review comment:
Invalid javadoc as there is no `throws` clause in a method signature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] pavlukhin commented on a change in pull request #7385:
IGNITE-12610: Disable h2.objectcache variable and add unit test
Posted by GitBox <gi...@apache.org>.
pavlukhin commented on a change in pull request #7385: IGNITE-12610: Disable h2.objectcache variable and add unit test
URL: https://github.com/apache/ignite/pull/7385#discussion_r385602105
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteH2PropertiesTest.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.h2.engine.SysProperties;
+import org.junit.Test;
+import org.junit.Before;
+
+/**
+ * Test to check the values of SysProperties variables are correct
+ */
+public class IgniteH2PropertiesTest extends GridCommonAbstractTest {
+ /** Instance name. */
+ private static final String INSTANCE_NAME = "test_node";
+
+ /** */
+ @Before
+ public void setUp() throws Exception {
+ try {
+ startGrid(INSTANCE_NAME, "examples/config/example-ignite.xml");
+ } finally {
+ stopAllGrids();
+ }
+ }
+
+ /**
+ * @throws Exception If failed.
+ */
+ @Test
+ public void testIgniteH2Properties() {
+ assertFalse(SysProperties.OBJECT_CACHE);
+ assertFalse(SysProperties.serializeJavaObject);
+
+ assertTrue(SysProperties.OBJECT_CACHE_MAX_PER_ELEMENT_SIZE == 0);
+ assertTrue("false".equals(System.getProperty("h2.optimizeTwoEquals")));
+ assertTrue("false".equals(System.getProperty("h2.dropRestrict")));
Review comment:
`assertEquals` seems to be better for these checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] pavlukhin commented on a change in pull request #7385:
IGNITE-12610: Disable h2.objectcache variable and add unit test
Posted by GitBox <gi...@apache.org>.
pavlukhin commented on a change in pull request #7385: IGNITE-12610: Disable h2.objectcache variable and add unit test
URL: https://github.com/apache/ignite/pull/7385#discussion_r385601597
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteH2PropertiesTest.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.h2.engine.SysProperties;
+import org.junit.Test;
+import org.junit.Before;
+
+/**
+ * Test to check the values of SysProperties variables are correct
+ */
+public class IgniteH2PropertiesTest extends GridCommonAbstractTest {
+ /** Instance name. */
+ private static final String INSTANCE_NAME = "test_node";
+
+ /** */
+ @Before
+ public void setUp() throws Exception {
+ try {
+ startGrid(INSTANCE_NAME, "examples/config/example-ignite.xml");
+ } finally {
Review comment:
Code-style: `finally` should go from a new line here. Check https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-BracesandIdentation for more details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] pavlukhin commented on a change in pull request #7385:
IGNITE-12610: Disable h2.objectcache variable and add unit test
Posted by GitBox <gi...@apache.org>.
pavlukhin commented on a change in pull request #7385: IGNITE-12610: Disable h2.objectcache variable and add unit test
URL: https://github.com/apache/ignite/pull/7385#discussion_r385599192
##########
File path: modules/indexing/src/test/java/org/apache/ignite/internal/processors/cache/IgniteH2PropertiesTest.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.processors.cache;
+
+import org.apache.ignite.testframework.junits.common.GridCommonAbstractTest;
+import org.h2.engine.SysProperties;
+import org.junit.Test;
+import org.junit.Before;
+
+/**
+ * Test to check the values of SysProperties variables are correct
+ */
+public class IgniteH2PropertiesTest extends GridCommonAbstractTest {
+ /** Instance name. */
+ private static final String INSTANCE_NAME = "test_node";
+
+ /** */
+ @Before
+ public void setUp() throws Exception {
Review comment:
I suggest to restructure the test to follow usual testing logic. Code of a test consists of following steps:
1. Execute some actions which are going to be checked is this test (start grid).
2. Checks that an actual result is as expected (H2 properties have desired values).
setUp/tearDown methods are usually used to prepare/cleanup an environment for test methods and their effects usually are not checked in test methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services