You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "swebb2066 (via GitHub)" <gi...@apache.org> on 2024/01/07 07:01:11 UTC
[PR] Remove unnecessary delays in unit tests [logging-log4cxx]
swebb2066 opened a new pull request, #325:
URL: https://github.com/apache/logging-log4cxx/pull/325
The delay in VectorAppender does not seem to be currently required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unnecessary delays in unit tests [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 merged PR #325:
URL: https://github.com/apache/logging-log4cxx/pull/325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unnecessary delays in unit tests [logging-log4cxx]
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on PR #325:
URL: https://github.com/apache/logging-log4cxx/pull/325#issuecomment-1880111924
Do we even need _any_ delays? I think with the clock mocking that I did a while ago we don't need any delays, we just advance our fake clock the correct number of milliseconds. It does it in the timebasedrollingtest only at the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove unnecessary delays in unit tests [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 commented on PR #325:
URL: https://github.com/apache/logging-log4cxx/pull/325#issuecomment-1880248661
> Do we even need any delays?
The reason for the delay is known only to Michael CATANZARITI who created vertorappender.cpp in 2003 (see commit fc5053e14).
On closer inspection I think the delay was for asyncappendertestcase test3 to use blocking to ensure the async thread does not remove all the logging events until the appender is closed.
I will update the code using this new hypothesis
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org