You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/01/09 14:31:48 UTC
[GitHub] jaylindquist commented on issue #6618: Support preselect_filters
without filter_box IDs
jaylindquist commented on issue #6618: Support preselect_filters without filter_box IDs
URL: https://github.com/apache/incubator-superset/pull/6618#issuecomment-452716167
@graceguo-supercat All existing functionality is still supported for `preselect_filters`. However, the 'Share Dashboard' generated link was changed to no longer use filter box IDs.
For the current implementation of Superset, if you have two filter boxes, both with a 'country' filter, selecting 'Bhutan' in one filter box still applies the filter across all charts -- including other filter boxes (the other filter box is blank, but only allows you to select 'Bhutan' as a filter). This all works as before.
When visiting the dashboard with`preselect_filters={"75":{"country":["Bhutan"]}}`, current functionality will set filter box 75 'country' to 'Bhutan' while leaving the other filter box blank, but only able to select 'Bhutan'. This functionality is also still supported in the PR when `preselect_filters` uses the format with IDs.
Existing functionality in version 0.28.1:
The noticeable change is when visiting the dashboard with `preselect_filters={"country":["Bhutan"]}`. In that case, both filter boxes will have their 'country' filter set to 'Bhutan'.
New functionality in this PR:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org