You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/03/16 12:09:56 UTC
[GitHub] [fineract] galovics opened a new pull request #2154: FINERACT-849: Minor fixes + docs for EclipseLink/PostgreSQL support
galovics opened a new pull request #2154:
URL: https://github.com/apache/fineract/pull/2154
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #2154: FINERACT-849: Minor fixes + docs for EclipseLink/PostgreSQL support
Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #2154:
URL: https://github.com/apache/fineract/pull/2154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #2154: FINERACT-849: Minor fixes + docs for EclipseLink/PostgreSQL support
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #2154:
URL: https://github.com/apache/fineract/pull/2154#discussion_r828044125
##########
File path: fineract-doc/build.gradle
##########
@@ -44,14 +44,11 @@ asciidoctorj {
version = '2.4.0'
attributes = [
- revnumber: {
- project.version.toString()
- },
generated: "${buildDir}/generated/asciidoc",
imagesdir: 'images',
diagrams: 'diagrams',
- years: '2015-2020',
- revnumber: "$version".toString(),
+ years: '2015-2022',
+ revnumber: '1.7.0',
Review comment:
hmmm... that way you always have to remember to set this version thing when you do a release... versioning is now handled by a Gradle plugin (in between releases you'll see Git hashes that clearly indicate against which commit this doc was created)... any specific reason why this should be fixed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a change in pull request #2154: FINERACT-849: Minor fixes + docs for EclipseLink/PostgreSQL support
Posted by GitBox <gi...@apache.org>.
galovics commented on a change in pull request #2154:
URL: https://github.com/apache/fineract/pull/2154#discussion_r828051324
##########
File path: fineract-doc/build.gradle
##########
@@ -44,14 +44,11 @@ asciidoctorj {
version = '2.4.0'
attributes = [
- revnumber: {
- project.version.toString()
- },
generated: "${buildDir}/generated/asciidoc",
imagesdir: 'images',
diagrams: 'diagrams',
- years: '2015-2020',
- revnumber: "$version".toString(),
+ years: '2015-2022',
+ revnumber: '1.7.0',
Review comment:
Good catch, I just simply forgot to move this back to the original code. :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org