You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "hiroyuki-sato (via GitHub)" <gi...@apache.org> on 2026/08/06 09:20:51 UTC

[PR] GH-50820: [CI][Dev] Bump ShellCheck to v0.11.0 and simplify pre-commit file patterns for the ci directory [arrow]

hiroyuki-sato opened a new pull request, #50821:
URL: https://github.com/apache/arrow/pull/50821

   ### Rationale for this change
   
   This is the sub issue #44748.
   
   * Now that all `ci/*.sh` files pass ShellCheck, simplify the pre-commit file pattern.
   * Bump ShellCheck to v0.11.0
   
   ### What changes are included in this PR?
   
   * Simplify pre-commit file patterns for the `ci` directory
   * Bump ShellCheck to v0.11.0
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50820: [CI][Dev] Bump ShellCheck to v0.11.0 and simplify pre-commit file patterns for the ci directory [arrow]

Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50821:
URL: https://github.com/apache/arrow/pull/50821#issuecomment-5203553065

   @raulcd Thanks
   
   There are still more than 35 files with ShellCheck violations in other directories.
   I'll continue working on them.
   
   * cpp/build-support/vendor-flatbuffers.sh
   * cpp/build-support/fuzzing/generate_corpuses.sh
   * cpp/build-support/run-test.sh
   * cpp/build-support/trim-boost.sh
   * cpp/build-support/update-flatbuffers.sh
   * dev/tasks/linux-packages/yum/build.sh
   * dev/tasks/linux-packages/apt/build.sh
   * dev/tasks/matlab/rename_macos_dynamic_libraries.sh
   * dev/conbench_envs/hooks.sh
   * dev/release/git-vars.sh
   * dev/release/post-06-ruby.sh
   * dev/release/03-binary-submit.sh
   * dev/release/verify-apt.sh
   * dev/release/verify-yum.sh
   * dev/release/run-rat.sh
   * dev/release/utils-create-release-tarball.sh
   * dev/release/06-matlab-upload.sh
   * dev/release/utils-binary.sh
   * dev/release/post-04-website.sh
   * dev/release/setup-gpg-agent.sh
   * dev/release/04-binary-download.sh
   * dev/release/01-prepare.sh
   * dev/release/post-12-homebrew.sh
   * dev/release/setup-ubuntu.sh
   * dev/release/10-vote-email.sh
   * dev/release/binary/runner.sh
   * dev/release/post-11-msys2.sh
   * dev/release/post-10-bump-versions.sh
   * dev/release/utils-prepare.sh
   * dev/release/02-source.sh
   * dev/release/verify-release-candidate.sh
   * dev/archery/generate_files_for_endian_test.sh
   * dev/merge_arrow_pr.sh
   * r/tools/download_dependencies_R.sh
   * r/inst/build_arrow_static.sh
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50820: [CI][Dev] Bump ShellCheck to v0.11.0 and simplify pre-commit file patterns for the ci directory [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50821:
URL: https://github.com/apache/arrow/pull/50821#issuecomment-5212283048

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5f9495eab06ffa3b94866380f4012c62ddf8b5ed.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/92767347039) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50820: [CI][Dev] Bump ShellCheck to v0.11.0 and simplify pre-commit file patterns for the ci directory [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #50821:
URL: https://github.com/apache/arrow/pull/50821#issuecomment-5212283257

   After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 5f9495eab06ffa3b94866380f4012c62ddf8b5ed.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/92767350794) has more details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50820: [CI][Dev] Bump ShellCheck to v0.11.0 and simplify pre-commit file patterns for the ci directory [arrow]

Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #50821:
URL: https://github.com/apache/arrow/pull/50821


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50820: [CI][Dev] Bump ShellCheck to v0.11.0 and simplify pre-commit file patterns for the ci directory [arrow]

Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50821:
URL: https://github.com/apache/arrow/pull/50821#issuecomment-5202895750

   ShellCheck worked as I expected.
   
   https://github.com/apache/arrow/actions/runs/31088709301/job/92574249072?pr=50821#step:5:182
   
   ```
   In ci/scripts/c_glib_build.sh line 26:
   : ${ARROW_GLIB_WERROR:=false}
     ^-------------------------^ SC2223 (info): This default assignment may cause DoS due to globbing. Quote it.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50820: [CI][Dev] Bump ShellCheck to v0.11.0 and simplify pre-commit file patterns for the ci directory [arrow]

Posted by "hiroyuki-sato (via GitHub)" <gi...@apache.org>.
hiroyuki-sato commented on PR #50821:
URL: https://github.com/apache/arrow/pull/50821#issuecomment-5202787372

   I'm intentionally introducing errors into a shell script to verify that ShellCheck reports them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-50820: [CI][Dev] Bump ShellCheck to v0.11.0 and simplify pre-commit file patterns for the ci directory [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #50821:
URL: https://github.com/apache/arrow/pull/50821#issuecomment-5202761230

   :warning: GitHub issue #50820 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org