[jira] Commented: (LUCENENET-102) GermanStemmer.cs has numerous string substring errors

["George Aroush (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENENET-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533006 ] 

George Aroush commented on LUCENENET-102:
-----------------------------------------

Hi Stefan,

I compared the attached file, GermanStemmer.cs.diff, with the current SVN copy of Lucene.Net 2.0.  What you attached is completely different, here are some:

1) The copyright header is wrong,
2) The namespace you are using is "Lucene.Net.Analysis.DE", but the SVN one is "SF.Snowball.Ext"
3) The function signature of Stem() is different,
4) You have IsStemmable(), but the SVN one doesn't

Can you confirm that you generated this diff from Lucene.Net 2.0?

Regards,

-- George

> GermanStemmer.cs has numerous string substring errors
> -----------------------------------------------------
>
>                 Key: LUCENENET-102
>                 URL: https://issues.apache.org/jira/browse/LUCENENET-102
>             Project: Lucene.Net
>          Issue Type: Bug
>         Environment: Lucene.Net 2.0 using the GermanStemmer
>            Reporter: Stefan Rusek
>         Attachments: GermanStemmer.cs.diff
>
>
> When using the german stemmer that is included in the 2.0 release. The stemmer will throw ArgumentOutOfRangeException. We have fixed the issue in-house but wanted to get the fix incorporated into the actual Lucene.Net release so that future users don't have this problem. Below is an example stacktrace, and I will attach a diff as well.
> System.ArgumentOutOfRangeException: Index and length must refer to a location within the string.
> Parameter name: length
>   at System.String.InternalSubStringWithChecks(Int32 startIndex, Int32 length, Boolean fAlwaysCopy)
>   at Lucene.Net.Analysis.DE.GermanStemmer.Strip(StringBuilder buffer) in c:\src-hosted\fogcreek\FogBugz\FogUtil.Search\FogUtil.Search\Lucene.Net\Analysis\DE\GermanStemmer.cs:line 88
>   at Lucene.Net.Analysis.DE.GermanStemmer.Stem(String term) in c:\src-hosted\fogcreek\FogBugz\FogUtil.Search\FogUtil.Search\Lucene.Net\Analysis\DE\GermanStemmer.cs:line 54
>   at Lucene.Net.Analysis.DE.GermanStemFilter.Next() in c:\src-hosted\fogcreek\FogBugz\FogUtil.Search\FogUtil.Search\Lucene.Net\Analysis\DE\GermanStemFilter.cs:line 67
>   at Lucene.Net.Index.DocumentWriter.InvertDocument(Document doc) in c:\src-hosted\fogcreek\FogBugz\FogUtil.Search\FogUtil.Search\Lucene.Net\Index\DocumentWriter.cs:line 181
>   at Lucene.Net.Index.DocumentWriter.AddDocument(String segment, Document doc) in c:\src-hosted\fogcreek\FogBugz\FogUtil.Search\FogUtil.Search\Lucene.Net\Index\DocumentWriter.cs:line 106
>   at Lucene.Net.Index.IndexWriter.AddDocument(Document doc, Analyzer analyzer) in c:\src-hosted\fogcreek\FogBugz\FogUtil.Search\FogUtil.Search\Lucene.Net\Index\IndexWriter.cs:line 626
>   at Lucene.Net.Index.IndexWriter.AddDocument(Document doc) in c:\src-hosted\fogcreek\FogBugz\FogUtil.Search\FogUtil.Search\Lucene.Net\Index\IndexWriter.cs:line 613

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.