You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Andras Salamon (Jira)" <ji...@apache.org> on 2020/06/04 15:02:00 UTC

[jira] [Commented] (LUCENE-9389) Enhance gradle logging calls validation: eliminate getMessage()

    [ https://issues.apache.org/jira/browse/LUCENE-9389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125990#comment-17125990 ] 

Andras Salamon commented on LUCENE-9389:
----------------------------------------

LUCENE-9382 turned off log validation for Lucene now this is only called for Solr. So even if I apply the patch provided in SOLR-14523 it will not list Lucene problems.

It is still useful to fix the Lucene log problems but without the checker they will come back eventually.

> Enhance gradle logging calls validation: eliminate getMessage()
> ---------------------------------------------------------------
>
>                 Key: LUCENE-9389
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9389
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Andras Salamon
>            Assignee: Erick Erickson
>            Priority: Minor
>
> SOLR-14280 fixed a logging problem in SolrConfig by removing a few getMessage() calls. We could enhance this solution by modifying gradle's logging calls validation and forbid getMessage() calls during logging. We should check the existing code and eliminate such calls.
> It is possible to suppress the warning using {{//logok}}.
> [~erickerickson] [~gerlowskija]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org