You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/27 18:16:22 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10594: feat: Dashboard Level Access : dashboard lists
codecov-commenter edited a comment on pull request #10594:
URL: https://github.com/apache/incubator-superset/pull/10594#issuecomment-673445076
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=h1) Report
> Merging [#10594](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7f1e4e441da8eff86ce31510a12a9f79e4317c9a?el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `77.77%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10594 +/- ##
==========================================
- Coverage 61.64% 61.57% -0.07%
==========================================
Files 815 816 +1
Lines 38498 38646 +148
Branches 3620 3620
==========================================
+ Hits 23733 23798 +65
- Misses 14579 14662 +83
Partials 186 186
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `62.05% <ø> (ø)` | |
| #python | `61.30% <77.77%> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.11% <ø> (ø)` | |
| [superset/dashbaord\_level\_access\_initializer.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJhb3JkX2xldmVsX2FjY2Vzc19pbml0aWFsaXplci5weQ==) | `0.00% <0.00%> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `39.67% <20.00%> (-0.33%)` | :arrow_down: |
| [superset/dashboards/security.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zZWN1cml0eS5weQ==) | `98.21% <98.21%> (ø)` | |
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==) | `91.66% <100.00%> (+0.75%)` | :arrow_up: |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.85% <100.00%> (+0.54%)` | :arrow_up: |
| [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=) | `91.66% <100.00%> (+0.75%)` | :arrow_up: |
| [superset/dashboards/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy91cGRhdGUucHk=) | `89.28% <100.00%> (+0.60%)` | :arrow_up: |
| [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5) | `97.91% <100.00%> (+1.36%)` | :arrow_up: |
| ... and [16 more](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=footer). Last update [7f1e4e4...e09a206](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org