You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "pgj (via GitHub)" <gi...@apache.org> on 2023/06/30 12:58:48 UTC
[GitHub] [couchdb-docker] pgj opened a new pull request, #249: fix: unbreak build
pgj opened a new pull request, #249:
URL: https://github.com/apache/couchdb-docker/pull/249
This change fixes the build and includes the following improvements:
- Move to Debian Bookworm because that is the release that includes OTP 25 out-of-the-box, which is required by `main`.
- Use a "slim" base image.
- Update SpiderMonkey to 78 and make it possible to build the image natively on `aarch64` (such as Apple M1).
- Avoid explicit `pip3 install` because that is not endorsed by Debian packaging. The Python package versions available in Bookworm shall suffice.
- Remove installation of extra FoundationDB packages — they seem to be gone, which breaks the build for every platform.
- Bump Node.js to 18, the latest recommend version.
- Chase changes in the `configure` script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-docker] pgj commented on a diff in pull request #249: fix: unbreak build
Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #249:
URL: https://github.com/apache/couchdb-docker/pull/249#discussion_r1248042933
##########
dev/Dockerfile:
##########
@@ -57,37 +56,30 @@ RUN set -eux; \
python3 \
libpython3-dev \
python3-pip \
+ python3.11-venv \
python3-sphinx \
+ python3-sphinx-rtd-theme \
Review Comment:
Removed the extra Python packages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-docker] big-r81 commented on a diff in pull request #249: fix: unbreak build
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #249:
URL: https://github.com/apache/couchdb-docker/pull/249#discussion_r1247940415
##########
dev/Dockerfile:
##########
@@ -57,37 +56,30 @@ RUN set -eux; \
python3 \
libpython3-dev \
python3-pip \
+ python3.11-venv \
python3-sphinx \
+ python3-sphinx-rtd-theme \
python3-setuptools \
+ python3-requests \
+ python3-hypothesis \
+ python3-nose \
wget
-RUN set -eux; \
- pip3 install --upgrade \
- sphinx_rtd_theme \
- nose \
- requests \
- hypothesis
-
-RUN set -eux; \
- wget https://www.foundationdb.org/downloads/6.3.9/ubuntu/installers/foundationdb-clients_6.3.9-1_amd64.deb; \
- wget https://www.foundationdb.org/downloads/6.3.9/ubuntu/installers/foundationdb-server_6.3.9-1_amd64.deb; \
- dpkg -i ./foundationdb*deb; \
- pkill -f fdb || true; pkill -f foundation || true; \
- rm -rf ./foundationdb*deb
-
# Node is special
RUN set -eux; \
curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add -; \
- echo 'deb https://deb.nodesource.com/node_10.x buster main' > /etc/apt/sources.list.d/nodesource.list; \
- echo 'deb-src https://deb.nodesource.com/node_10.x buster main' >> /etc/apt/sources.list.d/nodesource.list; \
+ echo 'deb https://deb.nodesource.com/node_18.x bullseye main' > /etc/apt/sources.list.d/nodesource.list; \
Review Comment:
Could we use the "normal" package sources from bookworm for Nodejs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-docker] big-r81 merged pull request #249: fix: unbreak build
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 merged PR #249:
URL: https://github.com/apache/couchdb-docker/pull/249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-docker] nickva commented on a diff in pull request #249: fix: unbreak build
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #249:
URL: https://github.com/apache/couchdb-docker/pull/249#discussion_r1247977430
##########
dev/Dockerfile:
##########
@@ -57,37 +56,30 @@ RUN set -eux; \
python3 \
libpython3-dev \
python3-pip \
+ python3.11-venv \
python3-sphinx \
+ python3-sphinx-rtd-theme \
Review Comment:
Good point, we bring both the mango tests and doc build dependencies in via a venv + requirements.txt file so those may not be needed. Try to to see if `make check` passes with just `python3-setuptools` and `python3.11-venv`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-docker] big-r81 commented on a diff in pull request #249: fix: unbreak build
Posted by "big-r81 (via GitHub)" <gi...@apache.org>.
big-r81 commented on code in PR #249:
URL: https://github.com/apache/couchdb-docker/pull/249#discussion_r1247938344
##########
dev/Dockerfile:
##########
@@ -57,37 +56,30 @@ RUN set -eux; \
python3 \
libpython3-dev \
python3-pip \
+ python3.11-venv \
python3-sphinx \
+ python3-sphinx-rtd-theme \
Review Comment:
Do we still need this explicitly (sphinx and sphinx-rtd-theme for docs), see https://github.com/apache/couchdb/blob/main/src/docs/requirements.txt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-docker] pgj commented on a diff in pull request #249: fix: unbreak build
Posted by "pgj (via GitHub)" <gi...@apache.org>.
pgj commented on code in PR #249:
URL: https://github.com/apache/couchdb-docker/pull/249#discussion_r1248041187
##########
dev/Dockerfile:
##########
@@ -57,37 +56,30 @@ RUN set -eux; \
python3 \
libpython3-dev \
python3-pip \
+ python3.11-venv \
python3-sphinx \
+ python3-sphinx-rtd-theme \
python3-setuptools \
+ python3-requests \
+ python3-hypothesis \
+ python3-nose \
wget
-RUN set -eux; \
- pip3 install --upgrade \
- sphinx_rtd_theme \
- nose \
- requests \
- hypothesis
-
-RUN set -eux; \
- wget https://www.foundationdb.org/downloads/6.3.9/ubuntu/installers/foundationdb-clients_6.3.9-1_amd64.deb; \
- wget https://www.foundationdb.org/downloads/6.3.9/ubuntu/installers/foundationdb-server_6.3.9-1_amd64.deb; \
- dpkg -i ./foundationdb*deb; \
- pkill -f fdb || true; pkill -f foundation || true; \
- rm -rf ./foundationdb*deb
-
# Node is special
RUN set -eux; \
curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | apt-key add -; \
- echo 'deb https://deb.nodesource.com/node_10.x buster main' > /etc/apt/sources.list.d/nodesource.list; \
- echo 'deb-src https://deb.nodesource.com/node_10.x buster main' >> /etc/apt/sources.list.d/nodesource.list; \
+ echo 'deb https://deb.nodesource.com/node_18.x bullseye main' > /etc/apt/sources.list.d/nodesource.list; \
Review Comment:
Sure. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org